From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 8 Nov 2007 10:08:39 -0600 From: Scott Wood To: David Gibson Subject: Re: [PATCH 3/4] Use embedded libfdt in the bootwrapper Message-ID: <20071108160839.GA4356@loki.buserror.net> References: <20071108033241.GA11695@localhost.localdomain> <20071108033603.8A29FDDE0F@ozlabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20071108033603.8A29FDDE0F@ozlabs.org> Cc: linuxppc-dev@ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Nov 08, 2007 at 02:36:03PM +1100, David Gibson wrote: > This patch incorporates libfdt (from the source embedded in an earlier > patch) into the wrapper.a library used by the bootwrapper. This > includes adding a libfdt_env.h file, which the libfdt sources need in > order to integrate into the bootwrapper environment, and a > libfdt-wrapper.c which provides glue to connect the bootwrappers > abstract device tree callbacks to the libfdt functions. > > In addition, this patch changes the various wrapper and platform files > to use libfdt functions instead of the older flatdevtree.c library. Won't we need to change the dtc invocation in the wrapper to reserve some space now? Speaking of which, it seems dtc still only supports setting the total size, as opposed to specifying the amount of additional space. It's still a bit crappy having to guess how much space to add, but it's better than needing to know how big the dtb will be without additional space. How hard would it be to get libfdt to dynamically allocate any extra space it needs? This is a regression from the current flat device tree code... -Scott