From: Wolfgang Denk <wd@denx.de>
To: "DI BACCO ANTONIO - technolabs" <Antonio.DiBacco@technolabs.it>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: mpc8xx_wdt.c : piscr is 16bit in linux2.4 but 32bit in linux2.6 ?!?!?!
Date: Sun, 11 Nov 2007 01:00:10 +0100 [thread overview]
Message-ID: <20071111000010.E51B3248D3@gemini.denx.de> (raw)
In-Reply-To: Your message of "Sun, 11 Nov 2007 00:03:23 +0100." <F1F6EC0C8B75034F9E3A79FC85122E8E2649ED@aquib01a>
In message <F1F6EC0C8B75034F9E3A79FC85122E8E2649ED@aquib01a> you wrote:
>
> in mpc8xx_wdt.c in linux2.4 (denx distribution) piscr is 16bit long but
According the UM, the PISCR is indeed a 16 bit register.
The current header files also declare a 16 bit register:
include/asm-ppc/8xx_immap.h: ushort sit_piscr;
> in the same file in linux 2.6.19-2 (denx distribution) is read and
> written with in_be32 and out_be32. It's strange.
We don't support MPC8xx in the 2.6 kernel tree yet. What you see
there, is original kernel.org code - the code in question is commit
ID 398f6858.
I think you are right - this is a bug in the code. Please submit a
patch.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Question: How does one get fresh air into a Russian church?
Answer: One clicks on an icon, and a window opens!
prev parent reply other threads:[~2007-11-11 0:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 23:03 mpc8xx_wdt.c : piscr is 16bit in linux2.4 but 32bit in linux2.6 ?!?!?! DI BACCO ANTONIO - technolabs
2007-11-11 0:00 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071111000010.E51B3248D3@gemini.denx.de \
--to=wd@denx.de \
--cc=Antonio.DiBacco@technolabs.it \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).