* mpc8xx_wdt.c : piscr is 16bit in linux2.4 but 32bit in linux2.6 ?!?!?!
@ 2007-11-10 23:03 DI BACCO ANTONIO - technolabs
2007-11-11 0:00 ` Wolfgang Denk
0 siblings, 1 reply; 2+ messages in thread
From: DI BACCO ANTONIO - technolabs @ 2007-11-10 23:03 UTC (permalink / raw)
To: linuxppc-embedded
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
Hi all,
in mpc8xx_wdt.c in linux2.4 (denx distribution) piscr is 16bit long but in the same file in linux 2.6.19-2 (denx distribution) is read and written with in_be32 and out_be32. It's strange.
Bye.
[-- Attachment #2: Type: text/html, Size: 634 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: mpc8xx_wdt.c : piscr is 16bit in linux2.4 but 32bit in linux2.6 ?!?!?!
2007-11-10 23:03 mpc8xx_wdt.c : piscr is 16bit in linux2.4 but 32bit in linux2.6 ?!?!?! DI BACCO ANTONIO - technolabs
@ 2007-11-11 0:00 ` Wolfgang Denk
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2007-11-11 0:00 UTC (permalink / raw)
To: DI BACCO ANTONIO - technolabs; +Cc: linuxppc-embedded
In message <F1F6EC0C8B75034F9E3A79FC85122E8E2649ED@aquib01a> you wrote:
>
> in mpc8xx_wdt.c in linux2.4 (denx distribution) piscr is 16bit long but
According the UM, the PISCR is indeed a 16 bit register.
The current header files also declare a 16 bit register:
include/asm-ppc/8xx_immap.h: ushort sit_piscr;
> in the same file in linux 2.6.19-2 (denx distribution) is read and
> written with in_be32 and out_be32. It's strange.
We don't support MPC8xx in the 2.6 kernel tree yet. What you see
there, is original kernel.org code - the code in question is commit
ID 398f6858.
I think you are right - this is a bug in the code. Please submit a
patch.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Question: How does one get fresh air into a Russian church?
Answer: One clicks on an icon, and a window opens!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-11 0:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-10 23:03 mpc8xx_wdt.c : piscr is 16bit in linux2.4 but 32bit in linux2.6 ?!?!?! DI BACCO ANTONIO - technolabs
2007-11-11 0:00 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).