From: Vitaly Bordug <vitb@kernel.crashing.org>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [POWERPC] [RFC] Fix 8xx tlbie definition
Date: Sat, 17 Nov 2007 01:28:37 +0300 [thread overview]
Message-ID: <20071117012837.4811d394@kernel.crashing.org> (raw)
In-Reply-To: <1195247189.28865.174.camel@pasglop>
On Sat, 17 Nov 2007 08:06:29 +1100
Benjamin Herrenschmidt wrote:
>
> On Fri, 2007-11-16 at 11:28 -0600, Josh Boyer wrote:
> > Git commit e701d269aa28996f3502780951fe1b12d5d66b49 introduced an
> > incorrect definition for _tlbie on PowerPC 8xx platforms. Only the
> > address should be passed to the function. This patch corrects the
> > definition of _tlbie and the related tlb flushing functions for 8xx.
> >
> > Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
>
> That conflicts with the patch I posted to fix it differently (I kept
> the additional argument).
>
Where can I grab it to give a try? My linuxppc archive is silent for some reason..
> Which one do we take ?
>
If your solution will work out, I'd agree with Kumar to have this thing consistent.
If not - It might be cheapier just to fix it this gross way, to keep 8xx stuff running.
--
Sincerely, Vitaly
next prev parent reply other threads:[~2007-11-16 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 17:28 [POWERPC] [RFC] Fix 8xx tlbie definition Josh Boyer
2007-11-16 21:06 ` Benjamin Herrenschmidt
2007-11-16 21:29 ` Kumar Gala
2007-11-16 22:28 ` Vitaly Bordug [this message]
2007-11-17 1:05 ` Benjamin Herrenschmidt
2007-11-17 17:06 ` Josh Boyer
2007-11-18 16:51 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071117012837.4811d394@kernel.crashing.org \
--to=vitb@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).