linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* annoying prinkts during vmemmap initialization
@ 2007-11-21 15:35 Christoph Hellwig
  2007-11-21 22:41 ` Stephen Rothwell
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2007-11-21 15:35 UTC (permalink / raw)
  To: apw; +Cc: linuxppc-dev

Hi Andi,

your patch 'ppc64: SPARSEMEM_VMEMMAP support' adds the following two lines:

+               printk(KERN_WARNING "vmemmap %08lx allocated at %p, "
+                                       "physical %p.\n", start, p, __pa(p));

in a loop around basically every page.  That's a lot of flooding (with
the wrong printk level, btw) and really slows down booting my cell blade
a lot (these only have a very slow serial over lan console).

Any reason to keep this?  And if yes can we please make it conditional
on some kind of vmemmap_debug boot option?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: annoying prinkts during vmemmap initialization
  2007-11-21 15:35 annoying prinkts during vmemmap initialization Christoph Hellwig
@ 2007-11-21 22:41 ` Stephen Rothwell
  2007-11-21 22:49   ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2007-11-21 22:41 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

Hi Christoph,

On Wed, 21 Nov 2007 16:35:26 +0100 Christoph Hellwig <hch@lst.de> wrote:
>
> Hi Andi,
> 
> your patch 'ppc64: SPARSEMEM_VMEMMAP support' adds the following two lines:
> 
> +               printk(KERN_WARNING "vmemmap %08lx allocated at %p, "
> +                                       "physical %p.\n", start, p, __pa(p));
> 
> in a loop around basically every page.  That's a lot of flooding (with
> the wrong printk level, btw) and really slows down booting my cell blade
> a lot (these only have a very slow serial over lan console).
> 
> Any reason to keep this?  And if yes can we please make it conditional
> on some kind of vmemmap_debug boot option?

These have been changed to pr_debug() in 2.6.24-rc3 kernel.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: annoying prinkts during vmemmap initialization
  2007-11-21 22:41 ` Stephen Rothwell
@ 2007-11-21 22:49   ` Christoph Hellwig
  0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2007-11-21 22:49 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linuxppc-dev, Christoph Hellwig

On Thu, Nov 22, 2007 at 09:41:45AM +1100, Stephen Rothwell wrote:
> > Any reason to keep this?  And if yes can we please make it conditional
> > on some kind of vmemmap_debug boot option?
> 
> These have been changed to pr_debug() in 2.6.24-rc3 kernel.

Ah, sorry for not checking.  Looks like the spufs tree lags a little
behind.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-11-21 22:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-21 15:35 annoying prinkts during vmemmap initialization Christoph Hellwig
2007-11-21 22:41 ` Stephen Rothwell
2007-11-21 22:49   ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).