From: Vitaly Bordug <vitb@kernel.crashing.org>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH revised 3/4] powerpc: Add EXPORT_SYMBOL_GPL for symbols required by fs_enet and cpm_uart
Date: Sun, 25 Nov 2007 19:18:33 +0300 [thread overview]
Message-ID: <20071125191833.1e76f335@kernel.crashing.org> (raw)
In-Reply-To: <47499711.2020409@freescale.com>
On Sun, 25 Nov 2007 09:38:57 -0600
Timur Tabi wrote:
> Jochen Friedrich wrote:
> > fs_enet and cpm_uart need symbols from commproc.c (for CPM1) or
> > cpm2_common.c. Add EXPORT_SYMBOL_GPL for cpmp, cpm_setbrg and
> > cpm2_immr, so the drivers can be compiled as modules.
As I told replying to prev mail, this needs to be addressed in respective driver(s), since
there is a way to retrieve such pointers without making them global.
This patch will exist in maillist as a workaround, but meanwhile I'll take a look at this problem.
>
> Maybe this is a stupid question, but why did you choose
> EXPORT_SYMBOL_GPL and not EXPORT_SYMBOL?
>
To prevent using those pointers from within non-GPL modules. kind of policy now...
--
Sincerely, Vitaly
next prev parent reply other threads:[~2007-11-25 16:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 17:35 [PATCH revised 3/4] powerpc: Add EXPORT_SYMBOL_GPL for symbols required by fs_enet and cpm_uart Jochen Friedrich
2007-11-25 15:38 ` Timur Tabi
2007-11-25 15:58 ` Jon Smirl
2007-11-25 16:18 ` Vitaly Bordug [this message]
2007-11-25 21:02 ` Dan Malek
2007-11-26 10:28 ` Vitaly Bordug
2007-11-26 11:15 ` Jochen Friedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071125191833.1e76f335@kernel.crashing.org \
--to=vitb@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).