linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Bordug <vitb@kernel.crashing.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: [PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar for fixed-link property
Date: Mon, 26 Nov 2007 17:29:15 +0300	[thread overview]
Message-ID: <20071126142915.19642.5842.stgit@localhost.localdomain> (raw)
In-Reply-To: <20071126142906.19642.45540.stgit@localhost.localdomain>


fixed-link says: register new "Fixed/emulated PHY", i.e. PHY that
not connected to the real MDIO bus.

Signed-off-by: Vitaly Bordug <vitb@kernel.crashing.org>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

---

 Documentation/powerpc/booting-without-of.txt |    3 +
 arch/powerpc/sysdev/fsl_soc.c                |   56 ++++++++++++++++++--------
 2 files changed, 42 insertions(+), 17 deletions(-)


diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
index e9a3cb1..cf25070 100644
--- a/Documentation/powerpc/booting-without-of.txt
+++ b/Documentation/powerpc/booting-without-of.txt
@@ -1254,6 +1254,9 @@ platforms are moved over to use the flattened-device-tree model.
       services interrupts for this device.
     - phy-handle : The phandle for the PHY connected to this ethernet
       controller.
+    - fixed-link : <a b c> where a is emulated phy id - choose any,
+      but unique to the all specified fixed-links, b is duplex - 0 half,
+      1 full, c is link speed - d#10/d#100/d#1000.
 
   Recommended properties:
 
diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
index 3ace747..e06a5c9 100644
--- a/arch/powerpc/sysdev/fsl_soc.c
+++ b/arch/powerpc/sysdev/fsl_soc.c
@@ -24,6 +24,7 @@
 #include <linux/platform_device.h>
 #include <linux/of_platform.h>
 #include <linux/phy.h>
+#include <linux/phy_fixed.h>
 #include <linux/spi/spi.h>
 #include <linux/fsl_devices.h>
 #include <linux/fs_enet_pd.h>
@@ -193,7 +194,6 @@ static const char *gfar_tx_intr = "tx";
 static const char *gfar_rx_intr = "rx";
 static const char *gfar_err_intr = "error";
 
-
 static int __init gfar_of_init(void)
 {
 	struct device_node *np;
@@ -277,29 +277,51 @@ static int __init gfar_of_init(void)
 			gfar_data.interface = PHY_INTERFACE_MODE_MII;
 
 		ph = of_get_property(np, "phy-handle", NULL);
-		phy = of_find_node_by_phandle(*ph);
+		if (ph == NULL) {
+			struct fixed_phy_status status = {};
+			u32 *fixed_link;
 
-		if (phy == NULL) {
-			ret = -ENODEV;
-			goto unreg;
-		}
+			fixed_link = (u32*)of_get_property(np, "fixed-link",NULL);
+			if (!fixed_link) {
+				ret = -ENODEV;
+				goto unreg;
+			}
 
-		mdio = of_get_parent(phy);
+			status.link = 1;
+			status.duplex = fixed_link[1];
+			status.speed = fixed_link[2];
+
+			ret = fixed_phy_add(PHY_POLL, fixed_link[0], &status);
+			if (ret)
+				goto unreg;
+
+			gfar_data.bus_id = 0;
+			gfar_data.phy_id = fixed_link[0];
+		} else {
+			phy = of_find_node_by_phandle(*ph);
+
+			if (phy == NULL) {
+				ret = -ENODEV;
+				goto unreg;
+			}
+
+			mdio = of_get_parent(phy);
+
+			id = of_get_property(phy, "reg", NULL);
+			ret = of_address_to_resource(mdio, 0, &res);
+			if (ret) {
+				of_node_put(phy);
+				of_node_put(mdio);
+				goto unreg;
+			}
+
+			gfar_data.phy_id = *id;
+			gfar_data.bus_id = res.start;
 
-		id = of_get_property(phy, "reg", NULL);
-		ret = of_address_to_resource(mdio, 0, &res);
-		if (ret) {
 			of_node_put(phy);
 			of_node_put(mdio);
-			goto unreg;
 		}
 
-		gfar_data.phy_id = *id;
-		gfar_data.bus_id = res.start;
-
-		of_node_put(phy);
-		of_node_put(mdio);
-
 		ret =
 		    platform_device_add_data(gfar_dev, &gfar_data,
 					     sizeof(struct

  reply	other threads:[~2007-11-26 14:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-26 14:29 [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality Vitaly Bordug
2007-11-26 14:29 ` Vitaly Bordug [this message]
2007-11-26 15:04   ` [PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar for fixed-link property Joakim Tjernlund
2007-11-27 11:39     ` Anton Vorontsov
2007-11-27 13:17       ` Joakim Tjernlund
2007-11-27 13:59         ` Anton Vorontsov
2007-11-27 14:01           ` Joakim Tjernlund
2007-11-26 14:29 ` [PATCH 3/3] [POWERPC] MPC8349E-mITX: Vitesse 7385 PHY is not connected to the MDIO bus Vitaly Bordug
2007-12-01 13:48 ` [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality Jochen Friedrich
2007-12-01 19:07   ` Vitaly Bordug
2007-12-01 21:34   ` Anton Vorontsov
2007-12-01 22:22     ` Vitaly Bordug
2007-12-01 23:27     ` Stephen Rothwell
2007-12-02 11:54     ` [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHYlayer functionality Joakim Tjernlund
2007-12-02 12:13       ` Anton Vorontsov
2007-12-01 21:59 ` [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality Jeff Garzik
2007-12-01 22:16   ` Vitaly Bordug
2007-12-04 20:07 ` Jeff Garzik
2007-12-05  1:22   ` Vitaly Bordug
  -- strict thread matches above, loose matches on Subject: below --
2007-12-06 22:51 Vitaly Bordug
2007-12-06 22:51 ` [PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar for fixed-link property Vitaly Bordug
2008-01-18  6:46   ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071126142915.19642.5842.stgit@localhost.localdomain \
    --to=vitb@kernel.crashing.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).