From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Linux/PPC Development <linuxppc-dev@ozlabs.org>,
Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [patch 2/9] ps3: Use symbolic names for video modes
Date: Tue, 27 Nov 2007 11:05:38 +1100 [thread overview]
Message-ID: <20071127110538.32f8dfef.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20071126172712.128301000@pademelon.sonytel.be>
[-- Attachment #1: Type: text/plain, Size: 1819 bytes --]
On Mon, 26 Nov 2007 18:24:57 +0100 Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
>
> @@ -594,20 +594,21 @@ static const struct {
> unsigned mask : 19;
> unsigned id : 4;
> } ps3av_preferred_modes[] = {
> - { .mask = PS3AV_RESBIT_WUXGA << SHIFT_VESA, .id = 13 },
> - { .mask = PS3AV_RESBIT_1920x1080P << SHIFT_60, .id = 5 },
> - { .mask = PS3AV_RESBIT_1920x1080P << SHIFT_50, .id = 10 },
> - { .mask = PS3AV_RESBIT_1920x1080I << SHIFT_60, .id = 4 },
> - { .mask = PS3AV_RESBIT_1920x1080I << SHIFT_50, .id = 9 },
> - { .mask = PS3AV_RESBIT_SXGA << SHIFT_VESA, .id = 12 },
> - { .mask = PS3AV_RESBIT_WXGA << SHIFT_VESA, .id = 11 },
> - { .mask = PS3AV_RESBIT_1280x720P << SHIFT_60, .id = 3 },
> - { .mask = PS3AV_RESBIT_1280x720P << SHIFT_50, .id = 8 },
> - { .mask = PS3AV_RESBIT_720x480P << SHIFT_60, .id = 2 },
> - { .mask = PS3AV_RESBIT_720x576P << SHIFT_50, .id = 7 },
> + { PS3AV_RESBIT_WUXGA << SHIFT_VESA, PS3AV_MODE_WUXGA },
> + { PS3AV_RESBIT_1920x1080P << SHIFT_60, PS3AV_MODE_1080P60 },
> + { PS3AV_RESBIT_1920x1080P << SHIFT_50, PS3AV_MODE_1080P50 },
> + { PS3AV_RESBIT_1920x1080I << SHIFT_60, PS3AV_MODE_1080I60 },
> + { PS3AV_RESBIT_1920x1080I << SHIFT_50, PS3AV_MODE_1080I50 },
> + { PS3AV_RESBIT_SXGA << SHIFT_VESA, PS3AV_MODE_SXGA },
> + { PS3AV_RESBIT_WXGA << SHIFT_VESA, PS3AV_MODE_WXGA },
> + { PS3AV_RESBIT_1280x720P << SHIFT_60, PS3AV_MODE_720P60 },
> + { PS3AV_RESBIT_1280x720P << SHIFT_50, PS3AV_MODE_720P50 },
> + { PS3AV_RESBIT_720x480P << SHIFT_60, PS3AV_MODE_480P },
> + { PS3AV_RESBIT_720x576P << SHIFT_50, PS3AV_MODE_576P },
Why did you remove the C99 style initialisers?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-11-27 0:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 17:24 [patch 0/9] ps3av/fb patches for 2.6.25 Geert Uytterhoeven
2007-11-26 17:24 ` [patch 1/9] ps3av: ps3av_get_scanmode() and ps3av_get_refresh_rate() are unused Geert Uytterhoeven
2007-11-26 17:24 ` [patch 2/9] ps3: Use symbolic names for video modes Geert Uytterhoeven
2007-11-27 0:05 ` Stephen Rothwell [this message]
2007-11-27 8:17 ` Geert Uytterhoeven
2007-11-26 17:24 ` [patch 3/9] ps3fb: Kill PS3FB_FULL_MODE_BIT Geert Uytterhoeven
2007-11-26 17:24 ` [patch 4/9] ps3fb: Inline macros that are used only once Geert Uytterhoeven
2007-11-26 17:25 ` [patch 5/9] ps3fb: Kill ps3fb_res Geert Uytterhoeven
2007-11-26 17:25 ` [patch 6/9] ps3fb: Make frame buffer offset unsigned int Geert Uytterhoeven
2007-11-26 17:25 ` [patch 7/9] ps3fb: Configurable black borders Geert Uytterhoeven
2007-11-26 17:25 ` [patch 8/9] ps3fb: Reorganize modedb handling Geert Uytterhoeven
2007-11-26 17:25 ` [patch 9/9] ps3fb: Round up video modes Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071127110538.32f8dfef.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox