From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Jon Loeliger <jdl@jdl.com>
Subject: Re: [PATCH][DTC] Fix whitespace in libfdt/fdt.h
Date: Wed, 28 Nov 2007 10:53:35 -0600 [thread overview]
Message-ID: <20071128165335.GA4597@loki.buserror.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0711280938440.3013@blarg.am.freescale.net>
On Wed, Nov 28, 2007 at 09:39:08AM -0600, Kumar Gala wrote:
> Take from u-boot whitespace fixup of the file
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> libfdt/fdt.h | 32 ++++++++++++++++----------------
> 1 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/libfdt/fdt.h b/libfdt/fdt.h
> index e00559a..48ccfd9 100644
> --- a/libfdt/fdt.h
> +++ b/libfdt/fdt.h
> @@ -4,22 +4,22 @@
> #ifndef __ASSEMBLY__
>
> struct fdt_header {
> - uint32_t magic; /* magic word FDT_MAGIC */
> - uint32_t totalsize; /* total size of DT block */
> - uint32_t off_dt_struct; /* offset to structure */
> - uint32_t off_dt_strings; /* offset to strings */
> - uint32_t off_mem_rsvmap; /* offset to memory reserve map */
> - uint32_t version; /* format version */
> - uint32_t last_comp_version; /* last compatible version */
> -
> - /* version 2 fields below */
> - uint32_t boot_cpuid_phys; /* Which physical CPU id we're
> + uint32_t magic; /* magic word FDT_MAGIC */
> + uint32_t totalsize; /* total size of DT block */
> + uint32_t off_dt_struct; /* offset to structure */
> + uint32_t off_dt_strings; /* offset to strings */
> + uint32_t off_mem_rsvmap; /* offset to memory reserve map */
> + uint32_t version; /* format version */
> + uint32_t last_comp_version; /* last compatible version */
I don't think this is an improvement... tabs are great for indentation, but
they suck for alignment.
-Scott
next prev parent reply other threads:[~2007-11-28 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 15:39 [PATCH][DTC] Fix whitespace in libfdt/fdt.h Kumar Gala
2007-11-28 15:46 ` Jon Loeliger
2007-11-28 16:53 ` Scott Wood [this message]
2007-11-28 17:09 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071128165335.GA4597@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).