[PATCH][DTC] Fix whitespace in libfdt/fdt.h

[PATCH][DTC] Fix whitespace in libfdt/fdt.h

[Kumar Gala]

Take from u-boot whitespace fixup of the file

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 libfdt/fdt.h |   32 ++++++++++++++++----------------
 1 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/libfdt/fdt.h b/libfdt/fdt.h
index e00559a..48ccfd9 100644
--- a/libfdt/fdt.h
+++ b/libfdt/fdt.h
@@ -4,22 +4,22 @@
 #ifndef __ASSEMBLY__

 struct fdt_header {
-	uint32_t magic;                  /* magic word FDT_MAGIC */
-	uint32_t totalsize;              /* total size of DT block */
-	uint32_t off_dt_struct;          /* offset to structure */
-	uint32_t off_dt_strings;         /* offset to strings */
-	uint32_t off_mem_rsvmap;         /* offset to memory reserve map */
-	uint32_t version;                /* format version */
-	uint32_t last_comp_version;      /* last compatible version */
-
-        /* version 2 fields below */
-	uint32_t boot_cpuid_phys;        /* Which physical CPU id we're
+	uint32_t magic;			 /* magic word FDT_MAGIC */
+	uint32_t totalsize;		 /* total size of DT block */
+	uint32_t off_dt_struct;		 /* offset to structure */
+	uint32_t off_dt_strings;	 /* offset to strings */
+	uint32_t off_mem_rsvmap;	 /* offset to memory reserve map */
+	uint32_t version;		 /* format version */
+	uint32_t last_comp_version;	 /* last compatible version */
+
+	/* version 2 fields below */
+	uint32_t boot_cpuid_phys;	 /* Which physical CPU id we're
 					    booting on */
 	/* version 3 fields below */
-        uint32_t size_dt_strings;        /* size of the strings block */
+	uint32_t size_dt_strings;	 /* size of the strings block */

 	/* version 17 fields below */
-	uint32_t size_dt_struct;         /* size of the structure block */
+	uint32_t size_dt_struct;	 /* size of the structure block */
 };

 struct fdt_reserve_entry {
@@ -41,12 +41,12 @@ struct fdt_property {

 #endif /* !__ASSEMBLY */

-#define FDT_MAGIC	0xd00dfeed      /* 4: version, 4: total size */
+#define FDT_MAGIC	0xd00dfeed	/* 4: version, 4: total size */
 #define FDT_TAGSIZE	sizeof(uint32_t)

-#define FDT_BEGIN_NODE	0x1             /* Start node: full name */
-#define FDT_END_NODE	0x2             /* End node */
-#define FDT_PROP	0x3             /* Property: name off,
+#define FDT_BEGIN_NODE	0x1		/* Start node: full name */
+#define FDT_END_NODE	0x2		/* End node */
+#define FDT_PROP	0x3		/* Property: name off,
 					   size, content */
 #define FDT_NOP		0x4		/* nop */
 #define FDT_END		0x9
-- 
1.5.3.4

Re: [PATCH][DTC] Fix whitespace in libfdt/fdt.h

[Jon Loeliger]

So, like, the other day Kumar Gala mumbled:
> Take from u-boot whitespace fixup of the file
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

Applied.

Thanks,
jdl

Re: [PATCH][DTC] Fix whitespace in libfdt/fdt.h

[Scott Wood]

On Wed, Nov 28, 2007 at 09:39:08AM -0600, Kumar Gala wrote:
> Take from u-boot whitespace fixup of the file
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  libfdt/fdt.h |   32 ++++++++++++++++----------------
>  1 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/libfdt/fdt.h b/libfdt/fdt.h
> index e00559a..48ccfd9 100644
> --- a/libfdt/fdt.h
> +++ b/libfdt/fdt.h
> @@ -4,22 +4,22 @@
>  #ifndef __ASSEMBLY__
> 
>  struct fdt_header {
> -	uint32_t magic;                  /* magic word FDT_MAGIC */
> -	uint32_t totalsize;              /* total size of DT block */
> -	uint32_t off_dt_struct;          /* offset to structure */
> -	uint32_t off_dt_strings;         /* offset to strings */
> -	uint32_t off_mem_rsvmap;         /* offset to memory reserve map */
> -	uint32_t version;                /* format version */
> -	uint32_t last_comp_version;      /* last compatible version */
> -
> -        /* version 2 fields below */
> -	uint32_t boot_cpuid_phys;        /* Which physical CPU id we're
> +	uint32_t magic;			 /* magic word FDT_MAGIC */
> +	uint32_t totalsize;		 /* total size of DT block */
> +	uint32_t off_dt_struct;		 /* offset to structure */
> +	uint32_t off_dt_strings;	 /* offset to strings */
> +	uint32_t off_mem_rsvmap;	 /* offset to memory reserve map */
> +	uint32_t version;		 /* format version */
> +	uint32_t last_comp_version;	 /* last compatible version */

I don't think this is an improvement...  tabs are great for indentation, but
they suck for alignment.

-Scott

Re: [PATCH][DTC] Fix whitespace in libfdt/fdt.h

[Jon Loeliger]

So, like, the other day Scott Wood mumbled:
> On Wed, Nov 28, 2007 at 09:39:08AM -0600, Kumar Gala wrote:
> > Take from u-boot whitespace fixup of the file
> > 
> > Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

[snip]

> I don't think this is an improvement...  tabs are great for indentation, but
> they suck for alignment.
> 
> -Scott

The issue was consistency with U-Boot for update reasons.
I'm fine with it....

jdl