From: linas@austin.ibm.com (Linas Vepstas)
To: Olaf Hering <olaf@aepfle.de>
Cc: linuxppc-dev@ozlabs.org, Will Schmidt <will_schmidt@vnet.ibm.com>,
paulus@samba.org
Subject: Re: [PATCH] powerpc: fix os-term usage on kernel panic
Date: Wed, 28 Nov 2007 14:09:32 -0600 [thread overview]
Message-ID: <20071128200932.GG19584@austin.ibm.com> (raw)
In-Reply-To: <20071128110037.GB31217@aepfle.de>
On Wed, Nov 28, 2007 at 12:00:37PM +0100, Olaf Hering wrote:
> On Tue, Nov 27, Will Schmidt wrote:
>
> > > -void rtas_os_term(char *str)
> > > +void rtas_panic_msg(char *str)
>
> > > - if (panic_timeout)
> > > - return;
>
> This change is wrong. Booting with panic=123 really means the system
> has to reboot in 123 seconds after a panic.
And it does.
> But, maybe this panic_timeout check was moved elsewhere.
It was *always* somewhere else; the check here was always wrong.
This change makes the os-term call happen after the the panic
timeout amount of time has elapsed.
--linas
next prev parent reply other threads:[~2007-11-28 20:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 1:28 [PATCH] powerpc: fix os-term usage on kernel panic Linas Vepstas
2007-11-28 0:15 ` Will Schmidt
2007-11-28 11:00 ` Olaf Hering
2007-11-28 20:09 ` Linas Vepstas [this message]
2007-11-29 10:41 ` Olaf Hering
2007-12-03 19:32 ` Linas Vepstas
2007-11-28 20:18 ` Linas Vepstas
2007-11-29 17:19 ` Will Schmidt
2007-11-30 5:56 ` Stephen Rothwell
2007-11-30 16:11 ` Will Schmidt
2007-11-30 19:26 ` Mike Strosaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071128200932.GG19584@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olaf@aepfle.de \
--cc=paulus@samba.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).