From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lixom.net (lixom.net [66.141.50.11]) by ozlabs.org (Postfix) with ESMTP id E19B4DDE0A for ; Tue, 4 Dec 2007 10:33:58 +1100 (EST) Date: Mon, 3 Dec 2007 17:37:52 -0600 From: Olof Johansson To: Jon Smirl Subject: Re: [PATCH 0/4] Series to add device tree naming to i2c Message-ID: <20071203233752.GA7041@lixom.net> References: <20071203212032.23543.3453.stgit@terra.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20071203212032.23543.3453.stgit@terra.home> Cc: linuxppc-dev@ozlabs.org, i2c@lm-sensors.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Dec 03, 2007 at 04:20:32PM -0500, Jon Smirl wrote: > The following series implements standard linux module aliasing for i2c modules > It then converts the mpc i2c driver from being a platform driver to an open > firmware one. I2C device names are picked up from the device tree. Module > aliasing is used to translate from device tree names into to linux kernel > names. Several i2c drivers are updated to use the new aliasing. May I ask why you want to modify the i2c layer instead of keeping the OF->i2c driver mapping in PPC code? It seems simpler to keep it in the PPC-specific code, since otherwise you might end up with confused i2c driver writers that make up their own OF names without knowing for sure that's what will be used. No? I recently posted (and asked Paulus to pull) a patch where I consolidate the fsl_soc mapping code so I can also use that on pasemi, and modified the pasemi platform code to setup the board_info from the device tree accordingly. Finally, whitespace is broken in several of your patches. -Olof