From: Greg KH <greg@kroah.com>
To: "Kyle A. Lucke" <klucke@us.ibm.com>, David Gibson <dwg@au1.ibm.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, linux-kernel@vger.kernel.org
Subject: drivers/net/iseries_veth.c dubious sysfs usage
Date: Wed, 5 Dec 2007 01:30:54 -0800 [thread overview]
Message-ID: <20071205093054.GA23229@kroah.com> (raw)
In doing a massive kobject cleanup of the kernel tree, I ran across the
iseries_veth.c driver.
It looks like the driver is creating a number of subdirectories under
the driver sysfs directory. This is odd and probably wrong. You want
these virtual connections to show up in the main sysfs device tree, not
under the driver directory.
I'll be glad to totally guess and try to move it around in the sysfs
tree, but odds are I'll get it all wrong as I can't really test this
out :)
Any hints on what this driver is trying to do in this sysfs directories?
thanks,
greg k-h
next reply other threads:[~2007-12-05 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 9:30 Greg KH [this message]
2007-12-05 11:10 ` drivers/net/iseries_veth.c dubious sysfs usage Michael Ellerman
2007-12-05 21:41 ` Greg KH
2007-12-06 3:48 ` Michael Ellerman
2007-12-11 23:56 ` [PATCH] Introduce driver_create/remove_dir Stephen Rothwell
2007-12-12 0:40 ` Randy Dunlap
2007-12-12 2:36 ` Stephen Rothwell
2007-12-13 7:10 ` Greg KH
2007-12-13 7:08 ` drivers/net/iseries_veth.c dubious sysfs usage Greg KH
2007-12-24 2:52 ` Stephen Rothwell
2007-12-24 5:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205093054.GA23229@kroah.com \
--to=greg@kroah.com \
--cc=dwg@au1.ibm.com \
--cc=klucke@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).