From: Greg KH <greg@kroah.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: Fix bus resource assignment on 32 bits with 64b resources
Date: Thu, 6 Dec 2007 17:00:01 -0800 [thread overview]
Message-ID: <20071207010001.GA23575@kroah.com> (raw)
In-Reply-To: <1196927934.7033.39.camel@pasglop>
On Thu, Dec 06, 2007 at 06:58:54PM +1100, Benjamin Herrenschmidt wrote:
>
> On Wed, 2007-12-05 at 22:39 -0800, Greg KH wrote:
> > > that is it can be either unsigned int, unsigned long or unsigned
> > long
> > > long... and we have no way to reliably printk that.
> >
> > We do this already just fine. Take a look in the kernel, I think we
> > just always cast it to long long to be uniform.
>
> I wanted to avoid that for two reasons:
>
> - casts are fugly
> - it adds support code to cast & handle 64 bits to 32 bits platforms
> that wouldn't normally need it
But that is how we already handle this today, in numerous places in the
kernel for this very type.
So, you can disagree that this is what we need to do, and if so, feel
free to fix up a whole lot of files in the tree :)
thanks,
greg k-h
next prev parent reply other threads:[~2007-12-07 0:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 6:40 [PATCH] pci: Fix bus resource assignment on 32 bits with 64b resources Benjamin Herrenschmidt
2007-12-06 3:22 ` Benjamin Herrenschmidt
2007-12-06 6:39 ` Greg KH
2007-12-06 7:58 ` Benjamin Herrenschmidt
2007-12-06 8:13 ` Geert Uytterhoeven
2007-12-06 8:16 ` Matthew Wilcox
2007-12-06 13:24 ` Kumar Gala
2007-12-06 13:35 ` Andreas Schwab
2007-12-06 22:37 ` Benjamin Herrenschmidt
2007-12-07 1:00 ` Greg KH [this message]
2007-12-09 7:16 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2007-12-10 6:15 Benjamin Herrenschmidt
2007-12-10 6:19 ` Benjamin Herrenschmidt
2007-12-04 6:08 Benjamin Herrenschmidt
2007-12-04 12:39 ` Geert Uytterhoeven
2007-12-04 19:57 ` Benjamin Herrenschmidt
2007-12-05 2:37 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071207010001.GA23575@kroah.com \
--to=greg@kroah.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).