From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp109.mail.mud.yahoo.com (smtp109.mail.mud.yahoo.com [209.191.85.219]) by ozlabs.org (Postfix) with SMTP id 1B533DDE0D for ; Fri, 7 Dec 2007 15:13:59 +1100 (EST) From: Nick Piggin To: Li Zefan Subject: Re: [PATCH 1/3] POWERPC: don't cast a pointer to pointer of list_head Date: Fri, 7 Dec 2007 15:07:09 +1100 References: <4757C1DA.6060603@cn.fujitsu.com> In-Reply-To: <4757C1DA.6060603@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-Id: <200712071507.10161.nickpiggin@yahoo.com.au> Cc: linuxppc-dev@ozlabs.org, Andrew Morton , paulus@samba.org, LKML List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thursday 06 December 2007 20:33, Li Zefan wrote: > The casting is safe only when the list_head member is the > first member of the structure. Even so, I don't think too safe :) It might technically work, but it could break more easily. So even if you find places where list_head is the first member of a structure, it would be nice to explicitly use the list_head member and avoid casts IMO. Thanks, Nick > Signed-off-by: Li Zefan > > --- > arch/ppc/syslib/ocp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/ppc/syslib/ocp.c b/arch/ppc/syslib/ocp.c > index 3f5be2c..d42d408 100644 > --- a/arch/ppc/syslib/ocp.c > +++ b/arch/ppc/syslib/ocp.c > @@ -376,7 +376,7 @@ ocp_remove_one_device(unsigned int vendor, unsigned int > function, int index) > > down_write(&ocp_devices_sem); > dev = __ocp_find_device(vendor, function, index); > - list_del((struct list_head *)dev); > + list_del(&dev->link); > up_write(&ocp_devices_sem); > > DBG(("ocp: ocp_remove_one_device(vendor: %x, function: %x, index: %d)... > done.\n", vendor, function, index));