linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC][RFC] MPC8360E-RDK: Device tree and board file
Date: Tue, 11 Dec 2007 11:30:27 +1100	[thread overview]
Message-ID: <20071211113027.bee17bc0.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20071210202934.GA32046@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

On Mon, 10 Dec 2007 23:29:34 +0300 Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
>
> +++ b/arch/powerpc/platforms/83xx/mpc836x_rdk.c
> +
> +static void __init mpc836x_rdk_setup_arch(void)
> +{
> +	struct device_node *np;
> +
> +	if (ppc_md.progress)
> +		ppc_md.progress("mpc836x_rdk_setup_arch()", 0);
> +
> +#ifdef CONFIG_QUICC_ENGINE
> +	qe_reset();
> +
> +	np = of_find_node_by_name(NULL, "par_io");
> +	if (np)
> +		par_io_init(np);
> +	else
> +		pr_warning("QE PIO not initialized!\n");

of_node_put(np); ?

> +static int __init mpc836x_rdk_probe(void)
> +{
> +	unsigned long root = of_get_flat_dt_root();
> +
> +	return of_flat_dt_is_compatible(root, "MPC836xRDK");

You need to include asm/prom.h to use the flattened device tree accessors.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-12-11  0:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-10 20:29 [PATCH] [POWERPC][RFC] MPC8360E-RDK: Device tree and board file Anton Vorontsov
2007-12-11  0:30 ` Stephen Rothwell [this message]
2007-12-11 17:19   ` Anton Vorontsov
2007-12-11 18:42 ` Kumar Gala
2007-12-15 16:23   ` Anton Vorontsov
2007-12-17  5:14     ` David Gibson
2007-12-17 17:03       ` Scott Wood
2007-12-17 17:10         ` Kim Phillips
2007-12-17 17:20           ` Scott Wood
2007-12-17 17:42             ` Kim Phillips
2007-12-17 18:26         ` Vitaly Bordug
2007-12-17 18:48           ` Scott Wood
2007-12-17 20:55             ` Vitaly Bordug
2007-12-18  3:51         ` David Gibson
2007-12-18 16:16           ` Scott Wood
2007-12-18 16:51             ` Anton Vorontsov
2007-12-18 22:39             ` David Gibson
2007-12-19 13:05         ` Anton Vorontsov
2007-12-19 16:15           ` Scott Wood
2007-12-19 16:36             ` Anton Vorontsov
2007-12-19 20:59         ` Anton Vorontsov
2007-12-18 15:53     ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071211113027.bee17bc0.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=avorontsov@ru.mvista.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).