* [PATCH] [POWERPC] iSeries: fix unregistering HV event handlers.
@ 2007-12-12 4:00 Stephen Rothwell
2007-12-12 5:53 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2007-12-12 4:00 UTC (permalink / raw)
To: paulus; +Cc: ppc-dev, Paul E. McKenney
Commit fbd568a3e61a7decb8a754ad952aaa5b5c82e9e5 ("Change
synchronize_kernel to _rcu and _sched") changed the deprecated
synchronize_kernel() in HvLpEvent_unregisterHandler() to
synchronize_rcu(). It turns out that it should have been
synchronize_sched().
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/powerpc/platforms/iseries/lpevents.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/iseries/lpevents.c b/arch/powerpc/platforms/iseries/lpevents.c
index 34bdbbe..02c1422 100644
--- a/arch/powerpc/platforms/iseries/lpevents.c
+++ b/arch/powerpc/platforms/iseries/lpevents.c
@@ -226,7 +226,7 @@ int HvLpEvent_unregisterHandler(HvLpEvent_Type eventType)
* other CPUs, and that the deleted handler isn't
* still running on another CPU when we return.
*/
- synchronize_rcu();
+ synchronize_sched();
return 0;
}
}
--
1.5.3.7
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] [POWERPC] iSeries: fix unregistering HV event handlers.
2007-12-12 4:00 [PATCH] [POWERPC] iSeries: fix unregistering HV event handlers Stephen Rothwell
@ 2007-12-12 5:53 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2007-12-12 5:53 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: ppc-dev, paulus
On Wed, Dec 12, 2007 at 03:00:56PM +1100, Stephen Rothwell wrote:
> Commit fbd568a3e61a7decb8a754ad952aaa5b5c82e9e5 ("Change
> synchronize_kernel to _rcu and _sched") changed the deprecated
> synchronize_kernel() in HvLpEvent_unregisterHandler() to
> synchronize_rcu(). It turns out that it should have been
> synchronize_sched().
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> arch/powerpc/platforms/iseries/lpevents.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/platforms/iseries/lpevents.c b/arch/powerpc/platforms/iseries/lpevents.c
> index 34bdbbe..02c1422 100644
> --- a/arch/powerpc/platforms/iseries/lpevents.c
> +++ b/arch/powerpc/platforms/iseries/lpevents.c
> @@ -226,7 +226,7 @@ int HvLpEvent_unregisterHandler(HvLpEvent_Type eventType)
> * other CPUs, and that the deleted handler isn't
> * still running on another CPU when we return.
> */
> - synchronize_rcu();
> + synchronize_sched();
> return 0;
> }
> }
> --
> 1.5.3.7
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-12 5:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-12 4:00 [PATCH] [POWERPC] iSeries: fix unregistering HV event handlers Stephen Rothwell
2007-12-12 5:53 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).