From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/20] [POWERPC] Reworking machine check handling and Fix 440/440A
Date: Thu, 13 Dec 2007 13:53:17 -0600 [thread overview]
Message-ID: <20071213135317.0cffbfb8@weaponx> (raw)
In-Reply-To: <20071213073836.A25EDDDF80@ozlabs.org>
On Thu, 13 Dec 2007 18:38:31 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> This adds a cputable function pointer for the CPU-side machine
> check handling. The semantic is still the same as the old one,
> the one in ppc_md. overrides the one in cputable, though
> ultimately we'll want to change that so the CPU gets first.
>=20
> This removes CONFIG_440A which was a problem for multiplatform
> kernels and instead fixes up the IVOR at runtime from a setup_cpu
> function. The "A" version of the machine check also tweaks the
> regs->trap value to differenciate the 2 versions at the C level.
[snip]
> Index: linux-merge/include/asm-ppc/reg_booke.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- linux-merge.orig/include/asm-ppc/reg_booke.h 2007-12-11 16:21:38.0000=
00000 +1100
> +++ linux-merge/include/asm-ppc/reg_booke.h 2007-12-11 16:23:21.000000000=
+1100
> @@ -207,7 +207,7 @@
> #define CCR1_TCS 0x00000080 /* Timer Clock Select */
>=20
> /* Bit definitions for the MCSR. */
> -#ifdef CONFIG_440A
> +#ifdef CONFIG_44x
> #define MCSR_MCS 0x80000000 /* Machine Check Summary */
> #define MCSR_IB 0x40000000 /* Instruction PLB Error */
> #define MCSR_DRB 0x20000000 /* Data Read PLB Error */
This breaks non-44x based arch/ppc platforms. For example ep405 in
arch/ppc fails with:
/home/jwboyer/src/linux-2.6/arch/ppc/kernel/traps.c: In function =E2=80=98m=
achine_check_440A=E2=80=99:
/home/jwboyer/src/linux-2.6/arch/ppc/kernel/traps.c:260: error: =E2=80=98MC=
SR_IB=E2=80=99 undeclared (first use in this function)
/home/jwboyer/src/linux-2.6/arch/ppc/kernel/traps.c:260: error: (Each undec=
lared identifier is reported only once
/home/jwboyer/src/linux-2.6/arch/ppc/kernel/traps.c:260: error: for each fu=
nction it appears in.)
/home/jwboyer/src/linux-2.6/arch/ppc/kernel/traps.c:262: error: =E2=80=98MC=
SR_DRB=E2=80=99 undeclared (first use in this function)
/home/jwboyer/src/linux-2.6/arch/ppc/kernel/traps.c:264: error: =E2=80=98MC=
SR_DWB=E2=80=99 undeclared (first use in this function)
/home/jwboyer/src/linux-2.6/arch/ppc/kernel/traps.c:266: error: =E2=80=98MC=
SR_TLBP=E2=80=99 undeclared (first use in this function)
/home/jwboyer/src/linux-2.6/arch/ppc/kernel/traps.c:268: error: =E2=80=98MC=
SR_ICP=E2=80=99 undeclared (first use in this function)
/home/jwboyer/src/linux-2.6/arch/ppc/kernel/traps.c:272: error: =E2=80=98MC=
SR_DCSP=E2=80=99 undeclared (first use in this function)
/home/jwboyer/src/linux-2.6/arch/ppc/kernel/traps.c:274: error: =E2=80=98MC=
SR_DCFP=E2=80=99 undeclared (first use in this function)
/home/jwboyer/src/linux-2.6/arch/ppc/kernel/traps.c:276: error: =E2=80=98MC=
SR_IMPE=E2=80=99 undeclared (first use in this function)
make[2]: *** [arch/ppc/kernel/traps.o] Error 1
The same is true for other platforms as well. Getting closer...
josh
next prev parent reply other threads:[~2007-12-13 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 7:38 [PATCH 1/20] [POWERPC] Reworking machine check handling and Fix 440/440A Benjamin Herrenschmidt
2007-12-13 19:53 ` Josh Boyer [this message]
2007-12-13 20:38 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213135317.0cffbfb8@weaponx \
--to=jwboyer@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).