From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dwalker1.mvista.com (gateway-1237.mvista.com [63.81.120.158]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id A1211DDE03 for ; Mon, 17 Dec 2007 05:31:25 +1100 (EST) Message-Id: <20071216181736.609241472@mvista.com> Date: Sun, 16 Dec 2007 00:00:01 -0800 Subject: [PATCH 1/2] [RESEND] ps3: vuart: fix error path locking Message-Id: <20071216181705.714358296@mvista.com> From: Daniel Walker To: akpm@linux-foundation.org Cc: matthias.kaehlcke@gmail.com, linux-kernel@vger.kernel.org, linux@bohmer.net, linuxppc-dev@ozlabs.org, mingo@elte.hu, kjwinchester@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This stray down would cause a permanent sleep which doesn't seem correct. The other uses of this semaphore appear fairly mutex like it's even initialized with init_MUTEX() .. So here a patch for removing this one down(). Signed-off-by: Geoff Levand Signed-off-by: Daniel Walker --- drivers/ps3/ps3-vuart.c | 1 - 1 file changed, 1 deletion(-) Index: linux-2.6.23/drivers/ps3/ps3-vuart.c =================================================================== --- linux-2.6.23.orig/drivers/ps3/ps3-vuart.c +++ linux-2.6.23/drivers/ps3/ps3-vuart.c @@ -1072,7 +1072,6 @@ static int ps3_vuart_probe(struct ps3_sy if (result) { dev_dbg(&dev->core, "%s:%d: drv->probe failed\n", __func__, __LINE__); - down(&vuart_bus_priv.probe_mutex); goto fail_probe; } --