* [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet
@ 2007-12-12 16:45 Jochen Friedrich
2007-12-17 23:20 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Jochen Friedrich @ 2007-12-12 16:45 UTC (permalink / raw)
To: Vitaly Bordug; +Cc: linuxppc-dev, linux-kernel, Jeff Garzik, netdev
This patch adds support to use the fixed-link property
of an ethernet node to fs_enet for the
CONFIG_PPC_CPM_NEW_BINDING case.
Signed-off-by: Jochen Friedrich <jochen@scram.de>
---
drivers/net/fs_enet/fs_enet-main.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
index f2a4d39..8220c70 100644
--- a/drivers/net/fs_enet/fs_enet-main.c
+++ b/drivers/net/fs_enet/fs_enet-main.c
@@ -1174,8 +1174,15 @@ static int __devinit find_phy(struct device_node *np,
struct device_node *phynode, *mdionode;
struct resource res;
int ret = 0, len;
+ const u32 *data;
+
+ data = of_get_property(np, "fixed-link", NULL);
+ if (data) {
+ snprintf(fpi->bus_id, 16, PHY_ID_FMT, 0, *data);
+ return 0;
+ }
- const u32 *data = of_get_property(np, "phy-handle", &len);
+ data = of_get_property(np, "phy-handle", &len);
if (!data || len != 4)
return -EINVAL;
--
1.5.3.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet
2007-12-12 16:45 [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet Jochen Friedrich
@ 2007-12-17 23:20 ` Jeff Garzik
2007-12-18 10:13 ` Jochen Friedrich
2007-12-18 15:10 ` Vitaly Bordug
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-12-17 23:20 UTC (permalink / raw)
To: Jochen Friedrich; +Cc: netdev, linux-kernel, linuxppc-dev
Jochen Friedrich wrote:
> This patch adds support to use the fixed-link property
> of an ethernet node to fs_enet for the
> CONFIG_PPC_CPM_NEW_BINDING case.
>
> Signed-off-by: Jochen Friedrich <jochen@scram.de>
> ---
> drivers/net/fs_enet/fs_enet-main.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
> index f2a4d39..8220c70 100644
> --- a/drivers/net/fs_enet/fs_enet-main.c
> +++ b/drivers/net/fs_enet/fs_enet-main.c
> @@ -1174,8 +1174,15 @@ static int __devinit find_phy(struct device_node *np,
> struct device_node *phynode, *mdionode;
> struct resource res;
> int ret = 0, len;
> + const u32 *data;
> +
> + data = of_get_property(np, "fixed-link", NULL);
> + if (data) {
> + snprintf(fpi->bus_id, 16, PHY_ID_FMT, 0, *data);
> + return 0;
> + }
>
> - const u32 *data = of_get_property(np, "phy-handle", &len);
> + data = of_get_property(np, "phy-handle", &len);
> if (!data || len != 4)
ACK, pass this through paulus?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet
2007-12-17 23:20 ` Jeff Garzik
@ 2007-12-18 10:13 ` Jochen Friedrich
2007-12-18 15:10 ` Vitaly Bordug
1 sibling, 0 replies; 4+ messages in thread
From: Jochen Friedrich @ 2007-12-18 10:13 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, linux-kernel, linuxppc-dev
Hi Jeff,
> ACK, pass this through paulus?
Yes, that's fine for me.
Thanks,
Jochen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet
2007-12-17 23:20 ` Jeff Garzik
2007-12-18 10:13 ` Jochen Friedrich
@ 2007-12-18 15:10 ` Vitaly Bordug
1 sibling, 0 replies; 4+ messages in thread
From: Vitaly Bordug @ 2007-12-18 15:10 UTC (permalink / raw)
To: Jochen Friedrich; +Cc: linuxppc-dev, linux-kernel, Jeff Garzik, netdev
On Mon, 17 Dec 2007 18:20:14 -0500
Jeff Garzik wrote:
> Jochen Friedrich wrote:
> > This patch adds support to use the fixed-link property
> > of an ethernet node to fs_enet for the
> > CONFIG_PPC_CPM_NEW_BINDING case.
> >
> > Signed-off-by: Jochen Friedrich <jochen@scram.de>
Acked-by: Vitaly Bordug <vitb@kernel.crashing.org>
Jochen,
will you resend the patch with all acks to paulus? I'll do that if not.
--
Sincerely, Vitaly
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-12-18 15:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-12 16:45 [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet Jochen Friedrich
2007-12-17 23:20 ` Jeff Garzik
2007-12-18 10:13 ` Jochen Friedrich
2007-12-18 15:10 ` Vitaly Bordug
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).