From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 19 Dec 2007 09:39:19 +1100 From: David Gibson To: Scott Wood Subject: Re: [PATCH] [POWERPC][RFC] MPC8360E-RDK: Device tree and board file Message-ID: <20071218223919.GC12254@localhost.localdomain> References: <20071210202934.GA32046@localhost.localdomain> <10D5CABD-442B-44DF-83D7-7FED5CD150E3@kernel.crashing.org> <20071215162331.GA24999@localhost.localdomain> <20071217051403.GB3477@localhost.localdomain> <20071217170303.GA4303@loki.buserror.net> <20071218035108.GA10212@localhost.localdomain> <4767F271.4090703@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4767F271.4090703@freescale.com> Cc: Stephen Rothwell , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Dec 18, 2007 at 10:16:49AM -0600, Scott Wood wrote: > David Gibson wrote: > > In this case the driver and binding have been developed together and > > for the time being it does require PHY nodes, obviously. I'm saying > > that maybe that requirement ought to be changed. > > I don't see why. > > > Well, phandle is only used to find the phy node itself, so it doesn't > > count. The only piece of information there is the reg - the PHY id. > > Following a phandle to another node is a fairly complex way of finding > > a single integer. > > > > Eh, I guess it's ok, but just directly giving the PHY id or a probe > > mask in the MAC node would also be fine (we do this for 4xx EMAC). > > It's not just a simple integer -- it also tells you which mdio bus > it's on. Ah, good point. Ok, I withdraw my complaints. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson