From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/4] sbc8560: add basic support for Wind River SBC8560 as powerpc
Date: Fri, 21 Dec 2007 10:37:29 -0500 [thread overview]
Message-ID: <20071221153728.GA20661@windriver.com> (raw)
In-Reply-To: <20071221101425.3408278c.sfr@canb.auug.org.au>
In message: Re: [PATCH 1/4] sbc8560: add basic support for Wind River SBC8560 as powerpc
on 21/12/2007 Stephen Rothwell wrote:
> Hi Paul,
>
> Just a couple of comments.
[...]
> The braces are unnecessary.
>
[...]
> We often say "if (!np)" and leave out the blank line above.
>
> > + if(of_address_to_resource(np, 0, &r)) {
> ^
> Put a space here.
[...]
> Need an of_node_pit(np) - cpm2_pic_init() does its own of_node_get.
>
> > +static struct cpm_pin sbc8560_pins[] = {
>
> const?
>
Sounds reasonable to me. I've integrated these into sbc8560.c (still
looking at how to handle the duart/dts based on feedback). Since I'd
inerited the things you'd requested fixes on from mpc85xx_ads.c, it
probably makes sense to fix them there too I would imagine. I'll send
that under its own subject in a minute.
Paul.
next prev parent reply other threads:[~2007-12-21 15:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 14:54 [PATCH 0/4] arch/powerpc support for SBC8560 board Paul Gortmaker
[not found] ` <442fe9c9343f3c694932bcdc5f819c493c33c76b.1198107769.git.paul.gortmaker@windriver.com>
2007-12-20 14:54 ` [PATCH 1/4] sbc8560: add basic support for Wind River SBC8560 as powerpc Paul Gortmaker
2007-12-20 23:14 ` Stephen Rothwell
2007-12-21 15:37 ` Paul Gortmaker [this message]
2007-12-20 23:49 ` Kumar Gala
[not found] ` <5864c84d6edc3562db2216ed46841f8004670106.1198107769.git.paul.gortmaker@windriver.com>
2007-12-20 14:54 ` [PATCH 2/4] CPM2: Make support for the CPM2 optional on 8560 based boards Paul Gortmaker
[not found] ` <31b0d5036a69a5302aa85a1b57896c77e27a9a7a.1198107769.git.paul.gortmaker@windriver.com>
2007-12-20 14:54 ` [PATCH 4/4] sbc8560: Add default .config file for Wind River SBC8560 Paul Gortmaker
[not found] ` <6be237dcf5b58d604afa6cea3079ec7de02a8de9.1198107769.git.paul.gortmaker@windriver.com>
2007-12-20 14:54 ` [PATCH 3/4] sbc8560: Add device tree source for Wind River SBC8560 board Paul Gortmaker
2007-12-20 23:54 ` Kumar Gala
2007-12-20 23:57 ` David Gibson
2007-12-21 17:40 ` Scott Wood
2007-12-20 23:49 ` [PATCH 0/4] arch/powerpc support for " Kumar Gala
2007-12-21 0:00 ` Paul Gortmaker
2007-12-20 23:56 ` Kumar Gala
2007-12-21 3:38 ` Paul Gortmaker
2007-12-21 3:59 ` David Gibson
2007-12-21 17:31 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071221153728.GA20661@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).