From: Wolfgang Denk <wd@denx.de>
To: Michael Buesch <mb@bu3sch.de>
Cc: Andrew Morton <akpm@osdl.org>,
paulus@au.ibm.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] powerpc: Do not fail build if mkimage is not available
Date: Thu, 27 Dec 2007 11:14:04 +0100 [thread overview]
Message-ID: <20071227101404.2C05F2405E@gemini.denx.de> (raw)
In-Reply-To: Your message of "Wed, 26 Dec 2007 17:08:51 +0100." <200712261708.51432.mb@bu3sch.de>
In message <200712261708.51432.mb@bu3sch.de> you wrote:
> On Wednesday 26 December 2007 17:03:43 Andreas Schwab wrote:
> > Michael Buesch <mb@bu3sch.de> writes:
> >
> > > + set +e
> > > mkimage -A ppc -O linux -T kernel -C gzip -a 00000000 -e 00000000 \
> > > $uboot_version -d "$vmz" "$ofile"
> > > + [ $? -eq 0 ] || exit 0
> > > + set -e
> >
> > mkimage ... || exit 0
>
> Could you PLEASE increase your verbosity?
> Why is mkimage || exit 0 any better than my test?
Because it works, while your's doesn't.
Make runs each command in a new shell. Your "set +e" is in vain, and
so is your test of the return code.
Um... doesn't make throw an error anyway when the execution of
mkimage fails?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Success in marriage is not so much finding the right person as it is
being the right person.
next prev parent reply other threads:[~2007-12-27 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-26 15:55 [PATCH v2] powerpc: Do not fail build if mkimage is not available Michael Buesch
2007-12-26 16:03 ` Andreas Schwab
2007-12-26 16:08 ` Michael Buesch
2007-12-26 16:19 ` Andreas Schwab
2007-12-27 10:14 ` Wolfgang Denk [this message]
2007-12-27 10:17 ` Andreas Schwab
2007-12-27 18:13 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071227101404.2C05F2405E@gemini.denx.de \
--to=wd@denx.de \
--cc=akpm@osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mb@bu3sch.de \
--cc=paulus@au.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).