linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Adrian Bunk <adrian.bunk@movial.fi>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	phil.el@wanadoo.fr, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org, paulus@samba.org,
	oprofile-list@lists.sourceforge.net
Subject: Re: [2.6.24 patch] restore Cell OProfile support
Date: Fri, 28 Dec 2007 14:30:08 -0500	[thread overview]
Message-ID: <20071228193008.GB23157@Krystal> (raw)
In-Reply-To: <20071228185649.GC4738@stusta.de>

* Adrian Bunk (adrian.bunk@movial.fi) wrote:
> This patch restores the Cell OProfile support that was killed by
> commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
> 
> Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
> 

Same here : why isn't this on by default when SPU_FS and OPROFILE are
enabled ?

> ---
> 
>  kernel/Kconfig.instrumentation |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> 6d1446d35d367fdbdd2a0a29e0d156646ff40630 
> diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation
> index a76635d..9d143e6 100644
> --- a/kernel/Kconfig.instrumentation
> +++ b/kernel/Kconfig.instrumentation
> @@ -53,2 +53,10 @@ config HARDWARE_PM
>  
> +config OPROFILE_CELL
> +	bool "OProfile for Cell Broadband Engine"
> +	depends on PPC && (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y) 
> +	default y
> +	help
> +	  Profiling of Cell BE SPUs requires special support enabled
> +	  by this option.
> +
>  config KPROBES
> 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

  reply	other threads:[~2007-12-28 20:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-28 18:56 [2.6.24 patch] restore Cell OProfile support Adrian Bunk
2007-12-28 19:30 ` Mathieu Desnoyers [this message]
2007-12-29 16:09 ` [2.6.24 patch] Fix " Mathieu Desnoyers
2007-12-31 16:10   ` Arnd Bergmann
2008-01-02 17:47     ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071228193008.GB23157@Krystal \
    --to=mathieu.desnoyers@polymtl.ca \
    --cc=adrian.bunk@movial.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=oprofile-list@lists.sourceforge.net \
    --cc=paulus@samba.org \
    --cc=phil.el@wanadoo.fr \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).