From: David Gibson <david@gibson.dropbear.id.au>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC drivers for the Freescale MPC8610 SoC
Date: Thu, 3 Jan 2008 15:44:32 +1100 [thread overview]
Message-ID: <20080103044432.GB25357@localhost.localdomain> (raw)
In-Reply-To: <477BADF5.9060003@freescale.com>
On Wed, Jan 02, 2008 at 09:29:57AM -0600, Timur Tabi wrote:
> Jon Smirl wrote:
> > On 12/19/07, Timur Tabi <timur@freescale.com> wrote:
> >> sound/soc/fsl/fsl_ssi.c | 614 +++++++++++++++++++
> >> sound/soc/fsl/fsl_ssi.h | 224 +++++++
> >
> > I'm confused about this part. You built a driver for the mpc8610 ssi
> > port. This port has a device tree entry.
> >
> > + ssi@16000 {
> > + compatible = "fsl,ssi";
> > + cell-index = <0>;
> > + reg = <16000 100>;
> > + interrupt-parent = <&mpic>;
> > + interrupts = <3e 2>;
> > + fsl,mode = "i2s-slave";
> > + codec {
> > + compatible = "cirrus,cs4270";
> > + /* MCLK source is a stand-alone oscillator */
> > + bus-frequency = <bb8000>;
> > + };
> > + };
> >
> > But then you don't create an of_platform_driver for this device.
> > Instead you create one for the fabric driver, struct
> > of_platform_driver mpc8610_hpcd_of_driver, and directly link the SSI
> > driver into it.
>
> That's the best plan I came up with. This is apparently fixed in ASoC
> V2. From ASoC V1's perspective, the fabric driver must be the master.
> However, it doesn't make sense to have a node in the device tree for the
> fabric driver, because there is no such "device". The fabric driver is
> an abstraction. So I need to chose some other node to probe the fabric
> driver with. I chose the SSI, since each SSI can have only one
> codec.
Instantiating the fabric driver off any node is wrong, precisely
because it is an abstraction. The fabric driver should be
instantiated by the platform code.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2008-01-03 4:44 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 0:03 [PATCH] ASoC drivers for the Freescale MPC8610 SoC Timur Tabi
2007-12-20 4:06 ` Olof Johansson
2007-12-20 14:24 ` Timur Tabi
2007-12-20 13:54 ` [alsa-devel] " Takashi Iwai
2007-12-20 17:04 ` Timur Tabi
2007-12-21 5:28 ` Lee Revell
2007-12-23 3:23 ` Timur Tabi
2007-12-20 22:39 ` Olof Johansson
2007-12-20 22:37 ` Timur Tabi
2007-12-20 22:43 ` Scott Wood
2007-12-23 2:58 ` Timur Tabi
2008-01-02 18:08 ` Scott Wood
2007-12-20 14:47 ` Jon Loeliger
2007-12-20 22:29 ` Jon Smirl
2007-12-20 22:32 ` Timur Tabi
2007-12-20 22:38 ` Jon Smirl
2007-12-20 22:40 ` Timur Tabi
2007-12-20 22:44 ` Scott Wood
2007-12-20 23:13 ` Jon Smirl
2007-12-21 0:00 ` David Gibson
2008-01-01 17:25 ` Jon Smirl
2008-01-01 17:42 ` Jon Smirl
2008-01-02 15:19 ` Timur Tabi
2008-01-02 15:34 ` Jon Smirl
2008-01-03 17:54 ` Timur Tabi
2008-01-03 18:13 ` Grant Likely
2008-01-03 18:20 ` Timur Tabi
2008-01-03 18:32 ` Grant Likely
2008-01-03 23:51 ` David Gibson
2008-01-05 2:39 ` [alsa-devel] " Timur Tabi
2008-01-06 0:46 ` David Gibson
2008-01-07 14:24 ` Mark Brown
2008-01-07 15:52 ` Timur Tabi
2008-01-07 18:28 ` Mark Brown
2008-01-10 3:49 ` David Gibson
2008-01-10 5:41 ` Jon Smirl
2008-01-10 10:30 ` Liam Girdwood
2008-01-10 15:39 ` Timur Tabi
2008-01-10 16:01 ` Grant Likely
2008-01-10 16:03 ` Timur Tabi
2008-01-10 20:10 ` Jon Smirl
2008-01-10 20:13 ` Timur Tabi
2008-01-10 20:24 ` Grant Likely
2008-01-10 20:35 ` Timur Tabi
2008-01-10 20:39 ` Jon Smirl
2008-01-10 20:44 ` Timur Tabi
2008-01-07 18:44 ` Liam Girdwood
2008-01-07 18:45 ` Timur Tabi
2008-01-02 16:12 ` Grant Likely
2008-01-03 18:08 ` Timur Tabi
2008-01-03 18:17 ` Grant Likely
2008-01-03 18:54 ` Scott Wood
2008-01-03 19:13 ` Grant Likely
2008-01-03 19:18 ` Scott Wood
2008-01-03 23:13 ` [alsa-devel] " Mark Brown
2008-01-05 2:35 ` Timur Tabi
2008-01-05 3:28 ` Grant Likely
2008-01-02 0:26 ` David Gibson
2008-01-02 15:10 ` Timur Tabi
2008-01-02 17:23 ` [alsa-devel] " Mark Brown
2008-01-03 18:23 ` Timur Tabi
2008-01-03 23:00 ` Mark Brown
2008-01-05 2:43 ` Timur Tabi
2008-01-07 13:37 ` Mark Brown
2008-01-02 4:27 ` Jon Smirl
2008-01-02 15:29 ` Timur Tabi
2008-01-02 15:56 ` Jon Smirl
2008-01-02 16:32 ` Grant Likely
2008-01-02 17:12 ` Jon Smirl
2008-01-02 17:22 ` Grant Likely
2008-01-02 18:43 ` Jon Smirl
2008-01-02 18:50 ` Grant Likely
2008-01-02 18:56 ` Jon Smirl
2008-01-03 4:46 ` David Gibson
2008-01-03 14:33 ` Jon Smirl
2008-01-03 17:57 ` Timur Tabi
2008-01-02 16:28 ` Grant Likely
2008-01-02 18:49 ` [alsa-devel] " Mark Brown
2008-01-03 18:16 ` Timur Tabi
2008-01-03 23:47 ` David Gibson
2008-01-04 13:39 ` Mark Brown
2008-01-03 18:14 ` Timur Tabi
2008-01-03 18:25 ` Grant Likely
2008-01-03 18:28 ` Timur Tabi
2008-01-03 18:38 ` Grant Likely
2008-01-03 4:44 ` David Gibson [this message]
2008-01-03 14:54 ` Jon Smirl
2008-01-04 5:01 ` David Gibson
2008-01-03 18:16 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080103044432.GB25357@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=alsa-devel@alsa-project.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).