From: Arnd Bergmann <arnd@arndb.de>
To: Li Li <r64360@freescale.com>
Cc: Wood Scott <scottwood@freescale.com>,
linuxppc-dev@ozlabs.org,
Phillips Kim <Kim.Phillips@freescale.com>,
Li Tony <Tony.Li@freescale.com>
Subject: Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support
Date: Thu, 3 Jan 2008 09:14:11 +0100 [thread overview]
Message-ID: <200801030914.12628.arnd@arndb.de> (raw)
In-Reply-To: <1199342440.7375.29.camel@Guyver>
On Thursday 03 January 2008, Li Li wrote:
> > * The detection method for the primary bus is somewhat fragile,
> > because
> > we depend on the order of the nodes in the device tree, which is not
> > specified to have a meaning. /Maybe/ there could be a property in
> > (at most) one of the PCI host bridge nodes saying that this specific
> > bus
> > is the primary one.
> >
>
> Put this primary in code is more save than in dts.
> The dts lacks error checking function. If provide error dts such as two
> pci hosts both has primary property will occur chaos.
It's easy enough to just panic() if you find more than one primary bus,
since the information from the device tree is static enough that one
will know how to fix this after seeing the error.
Arnd <><
next prev parent reply other threads:[~2008-01-03 8:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-02 11:16 [PATCH] powerpc: Add MPC837x PCIE controller RC mode support Li Li
2008-01-02 11:53 ` Arnd Bergmann
2008-01-03 6:40 ` Li Li
2008-01-03 8:14 ` Arnd Bergmann [this message]
2008-01-03 8:31 ` Li Li
2008-01-03 10:14 ` Arnd Bergmann
2008-01-03 10:08 ` Li Li
2008-01-02 15:23 ` Kumar Gala
2008-01-03 5:56 ` Li Li
2008-01-02 15:51 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801030914.12628.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Kim.Phillips@freescale.com \
--cc=Tony.Li@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=r64360@freescale.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).