* [PATCH] powerpc: #address-cells & #size-cells properties not inherited
@ 2008-01-03 0:07 Mark A. Greer
2008-01-03 1:46 ` Josh Boyer
2008-01-03 9:46 ` [PATCH] " David Gibson
0 siblings, 2 replies; 6+ messages in thread
From: Mark A. Greer @ 2008-01-03 0:07 UTC (permalink / raw)
To: linuxppc-dev; +Cc: David Gibson
From: Mark A. Greer <mgreer@mvista.com>
Fix error in booting-without-of.txt that indicates that a node can inherit
its #address-cells and #size-cells definitions from its parent's parent.
This is not correct and the latest dtc enforces it.
Signed-off-by: Mark A. Greer <mgreer@mvista.com>
---
Documentation/powerpc/booting-without-of.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
index ee0209a..58db5ea 100644
--- a/Documentation/powerpc/booting-without-of.txt
+++ b/Documentation/powerpc/booting-without-of.txt
@@ -671,10 +671,10 @@ device or bus to be described by the device tree.
In general, the format of an address for a device is defined by the
parent bus type, based on the #address-cells and #size-cells
-property. In the absence of such a property, the parent's parent
-values are used, etc... The kernel requires the root node to have
-those properties defining addresses format for devices directly mapped
-on the processor bus.
+properties. Note that the parent's parent definitions of #address-cells
+and #size-cells are not inhereted so every node with children must specify
+them. The kernel requires the root node to have those properties defining
+addresses format for devices directly mapped on the processor bus.
Those 2 properties define 'cells' for representing an address and a
size. A "cell" is a 32-bit number. For example, if both contain 2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: #address-cells & #size-cells properties not inherited
2008-01-03 0:07 [PATCH] powerpc: #address-cells & #size-cells properties not inherited Mark A. Greer
@ 2008-01-03 1:46 ` Josh Boyer
2008-01-03 15:32 ` Mark A. Greer
2008-01-03 15:40 ` [PATCH v2] " Mark A. Greer
2008-01-03 9:46 ` [PATCH] " David Gibson
1 sibling, 2 replies; 6+ messages in thread
From: Josh Boyer @ 2008-01-03 1:46 UTC (permalink / raw)
To: Mark A. Greer; +Cc: linuxppc-dev, David Gibson
On Wed, 2 Jan 2008 17:07:50 -0700
"Mark A. Greer" <mgreer@mvista.com> wrote:
> From: Mark A. Greer <mgreer@mvista.com>
>
> Fix error in booting-without-of.txt that indicates that a node can inherit
> its #address-cells and #size-cells definitions from its parent's parent.
> This is not correct and the latest dtc enforces it.
I'm lazy so I haven't checked myself, but by "latest dtc" does that
mean the DTC that's in the kernel now?
Things are going to be fun when we start saying generic things like
"latest DTC". And when upstream DTC gets new features or enforcements,
we'll have to have all the in-kernel DTS files patched up when that
version of DTC gets merged in-kernel. Just something to keep in mind
as we move along.
josh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: #address-cells & #size-cells properties not inherited
2008-01-03 1:46 ` Josh Boyer
@ 2008-01-03 15:32 ` Mark A. Greer
2008-01-03 16:01 ` Josh Boyer
2008-01-03 15:40 ` [PATCH v2] " Mark A. Greer
1 sibling, 1 reply; 6+ messages in thread
From: Mark A. Greer @ 2008-01-03 15:32 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, David Gibson
On Wed, Jan 02, 2008 at 07:46:40PM -0600, Josh Boyer wrote:
> On Wed, 2 Jan 2008 17:07:50 -0700
> "Mark A. Greer" <mgreer@mvista.com> wrote:
>
> > From: Mark A. Greer <mgreer@mvista.com>
> >
> > Fix error in booting-without-of.txt that indicates that a node can inherit
> > its #address-cells and #size-cells definitions from its parent's parent.
> > This is not correct and the latest dtc enforces it.
>
> I'm lazy so I haven't checked myself, but by "latest dtc" does that
> mean the DTC that's in the kernel now?
>
> Things are going to be fun when we start saying generic things like
> "latest DTC". And when upstream DTC gets new features or enforcements,
> we'll have to have all the in-kernel DTS files patched up when that
> version of DTC gets merged in-kernel. Just something to keep in mind
> as we move along.
Yeah, I thought about that last night, actually.
I think I'll just change that sentence to "This is not correct."
Avoid the issue :)
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: #address-cells & #size-cells properties not inherited
2008-01-03 15:32 ` Mark A. Greer
@ 2008-01-03 16:01 ` Josh Boyer
0 siblings, 0 replies; 6+ messages in thread
From: Josh Boyer @ 2008-01-03 16:01 UTC (permalink / raw)
To: Mark A. Greer; +Cc: linuxppc-dev, David Gibson
On Thu, 3 Jan 2008 08:32:56 -0700
"Mark A. Greer" <mgreer@mvista.com> wrote:
> On Wed, Jan 02, 2008 at 07:46:40PM -0600, Josh Boyer wrote:
> > On Wed, 2 Jan 2008 17:07:50 -0700
> > "Mark A. Greer" <mgreer@mvista.com> wrote:
> >
> > > From: Mark A. Greer <mgreer@mvista.com>
> > >
> > > Fix error in booting-without-of.txt that indicates that a node can inherit
> > > its #address-cells and #size-cells definitions from its parent's parent.
> > > This is not correct and the latest dtc enforces it.
> >
> > I'm lazy so I haven't checked myself, but by "latest dtc" does that
> > mean the DTC that's in the kernel now?
> >
> > Things are going to be fun when we start saying generic things like
> > "latest DTC". And when upstream DTC gets new features or enforcements,
> > we'll have to have all the in-kernel DTS files patched up when that
> > version of DTC gets merged in-kernel. Just something to keep in mind
> > as we move along.
>
> Yeah, I thought about that last night, actually.
> I think I'll just change that sentence to "This is not correct."
>
> Avoid the issue :)
Lazy! I like it ;)
josh
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] powerpc: #address-cells & #size-cells properties not inherited
2008-01-03 1:46 ` Josh Boyer
2008-01-03 15:32 ` Mark A. Greer
@ 2008-01-03 15:40 ` Mark A. Greer
1 sibling, 0 replies; 6+ messages in thread
From: Mark A. Greer @ 2008-01-03 15:40 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, David Gibson
From: Mark A. Greer <mgreer@mvista.com>
Fix error in booting-without-of.txt that indicates that a node can inherit
its #address-cells and #size-cells definitions from its parent's parent.
This is not correct.
Signed-off-by: Mark A. Greer <mgreer@mvista.com>
---
Documentation/powerpc/booting-without-of.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
index ee0209a..58db5ea 100644
--- a/Documentation/powerpc/booting-without-of.txt
+++ b/Documentation/powerpc/booting-without-of.txt
@@ -671,10 +671,10 @@ device or bus to be described by the device tree.
In general, the format of an address for a device is defined by the
parent bus type, based on the #address-cells and #size-cells
-property. In the absence of such a property, the parent's parent
-values are used, etc... The kernel requires the root node to have
-those properties defining addresses format for devices directly mapped
-on the processor bus.
+properties. Note that the parent's parent definitions of #address-cells
+and #size-cells are not inhereted so every node with children must specify
+them. The kernel requires the root node to have those properties defining
+addresses format for devices directly mapped on the processor bus.
Those 2 properties define 'cells' for representing an address and a
size. A "cell" is a 32-bit number. For example, if both contain 2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: #address-cells & #size-cells properties not inherited
2008-01-03 0:07 [PATCH] powerpc: #address-cells & #size-cells properties not inherited Mark A. Greer
2008-01-03 1:46 ` Josh Boyer
@ 2008-01-03 9:46 ` David Gibson
1 sibling, 0 replies; 6+ messages in thread
From: David Gibson @ 2008-01-03 9:46 UTC (permalink / raw)
To: Mark A. Greer; +Cc: linuxppc-dev, David Gibson
On Wed, Jan 02, 2008 at 05:07:50PM -0700, Mark A. Greer wrote:
> From: Mark A. Greer <mgreer@mvista.com>
>
> Fix error in booting-without-of.txt that indicates that a node can inherit
> its #address-cells and #size-cells definitions from its parent's parent.
> This is not correct and the latest dtc enforces it.
For small values of "enforce"; it's a warning only.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-01-03 16:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-03 0:07 [PATCH] powerpc: #address-cells & #size-cells properties not inherited Mark A. Greer
2008-01-03 1:46 ` Josh Boyer
2008-01-03 15:32 ` Mark A. Greer
2008-01-03 16:01 ` Josh Boyer
2008-01-03 15:40 ` [PATCH v2] " Mark A. Greer
2008-01-03 9:46 ` [PATCH] " David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).