From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Clifford Wolf <clifford@clifford.at>
Cc: linuxppc-dev@ozlabs.org, lkml <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [patch] powerpc systbl.h broken
Date: Thu, 3 Jan 2008 13:16:24 +1100 [thread overview]
Message-ID: <20080103131624.5a3e98e8.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20080102141127.GA11870@clifford.at>
Hi Clifford,
Thanks for the report.
PowerPC problems should be reported to linuxppc-dev@ozlabs.org.
This has been fixed in the current (approaching 2.6.24) kernel. It
should be fixed in 2.6.23.xx, so I have cc'd this to
stable@vger.kernel.org (and linuxppc-dev, of course).
(Also, please post patches inline, don't attach them. And you need to
reply to this with a Signed-off-by: line.)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
------------------------------------------------------------------------
From: Clifford Wolf <clifford@clifford.at>
Hi,
In current 2.6.23 (I have checked 2.6.23.12 and 2.6.23.9) the end of
include/asm-powerpc/systbl.h reads:
--snip--
SYSCALL_SPU(getcpu)
COMPAT_SYS(epoll_pwait)
COMPAT_SYS_SPU(utimensat)
COMPAT_SYS(fallocate)
COMPAT_SYS_SPU(signalfd)
COMPAT_SYS_SPU(timerfd)
SYSCALL_SPU(eventfd)
COMPAT_SYS_SPU(sync_file_range2)
--snap--
This obviously does not match the definitions in asm-powerpc/unistd.h:
--snip--
#define __NR_getcpu 302
#define __NR_epoll_pwait 303
#define __NR_utimensat 304
#define __NR_signalfd 305
#define __NR_timerfd 306
#define __NR_eventfd 307
#define __NR_sync_file_range2 308
#define __NR_fallocate 309
--snap--
which breaks the system calls 305 to 309 inclusive.
--- linux-2.6.23.12/include/asm-powerpc/systbl.h.orig 2008-01-02 15:09:04.000000000 +0100
+++ linux-2.6.23.12/include/asm-powerpc/systbl.h 2008-01-02 15:09:29.000000000 +0100
@@ -308,8 +308,8 @@
SYSCALL_SPU(getcpu)
COMPAT_SYS(epoll_pwait)
COMPAT_SYS_SPU(utimensat)
-COMPAT_SYS(fallocate)
COMPAT_SYS_SPU(signalfd)
COMPAT_SYS_SPU(timerfd)
SYSCALL_SPU(eventfd)
COMPAT_SYS_SPU(sync_file_range2)
+COMPAT_SYS(fallocate)
next parent reply other threads:[~2008-01-03 2:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080102141127.GA11870@clifford.at>
2008-01-03 2:16 ` Stephen Rothwell [this message]
2008-01-03 2:54 ` [patch] powerpc systbl.h broken Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080103131624.5a3e98e8.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=clifford@clifford.at \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox