From: Stefan Roese <sr@denx.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, Sean MacLennan <smaclennan@pikatech.com>
Subject: Re: [PATCH] i2c-ibm_iic driver
Date: Sat, 5 Jan 2008 13:58:33 +0100 [thread overview]
Message-ID: <200801051358.33473.sr@denx.de> (raw)
In-Reply-To: <200801051354.11202.arnd@arndb.de>
On Saturday 05 January 2008, Arnd Bergmann wrote:
> > > This is probably not specific enough. I'm rather sure that someone at
> > > IBM has implemented an i2c chip that this driver doesn't support. May=
be
> > >
> > > =A0=A0=A0=A0=A0=A0.compatible =3D "ibm,405-iic"
> > >
> > > or similar would be a better thing to check for.
> >
> > =A0=A0=A0=A0=A0=A0=A0=A0.compatible =3D "ibm,4xx-iic"
> >
> > please, since 405 and 440 have the same I2C controller.
>
> But that's not how compatible properties work -- they should not
> contain wildcards. If you have different devices that are
> backwards compatible, you should list the older one in all
> newer devices, e.g. the 440 can list that it is compatible
> with both ibm,405-iic and ibm,440-iic. If there was an earlier
> 401 that had iic as well, you may even want to include that
> in the device tree.
OK. Thanks for clarifying.
Best regards,
Stefan
next prev parent reply other threads:[~2008-01-05 12:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 2:57 [PATCH] i2c-ibm_iic driver Sean MacLennan
2008-01-05 11:24 ` Arnd Bergmann
2008-01-05 12:49 ` Stefan Roese
2008-01-05 12:54 ` Arnd Bergmann
2008-01-05 12:58 ` Stefan Roese [this message]
2008-01-05 18:36 ` Sean MacLennan
2008-01-05 19:18 ` Arnd Bergmann
2008-01-06 0:12 ` David Gibson
2008-01-08 2:03 ` [PATCH] i2c-ibm_iic driver - new patch Sean MacLennan
2008-01-08 4:52 ` Stephen Rothwell
2008-01-08 5:56 ` Sean MacLennan
2008-01-08 6:36 ` Stephen Rothwell
2008-01-08 18:35 ` Sean MacLennan
2008-01-08 19:33 ` Stefan Roese
2008-01-08 16:40 ` Scott Wood
2008-01-05 18:32 ` [PATCH] i2c-ibm_iic driver Sean MacLennan
2008-01-05 18:30 ` Sean MacLennan
2008-01-08 1:16 ` Sean MacLennan
2008-02-19 2:02 ` [PATCH] i2c-ibm_iic driver bonus patch Sean MacLennan
2008-02-19 3:27 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2008-01-09 17:05 [PATCH] i2c-ibm_iic driver Sean MacLennan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801051358.33473.sr@denx.de \
--to=sr@denx.de \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=smaclennan@pikatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).