From: Grant Likely <grant.likely@secretlab.ca>
To: dragos.carp@toptica.com, linuxppc-dev@ozlabs.org
Subject: [RFC 0/2] mpc5200: eliminate direct manipulation of shared registers from SPI driver
Date: Mon, 07 Jan 2008 12:03:30 -0700 [thread overview]
Message-ID: <20080107185849.13535.38262.stgit@trillian.secretlab.ca> (raw)
The mpc5200 PSC SPI driver driver directly manipulates the port_config
and the CDM registers on the mpc5200 which it should not do. port_config
should only be manipulated from within the board specific platform code
and the CDM registers are shared between multiple devices.
This patch eliminates the port_config manipulations and adds a common
routine for adjusting CDM settings. Boards using the SPI driver will
need to add the required port_config changes to either the boot firmware
or the platform code.
If there are no objections, I plan to ask Paulus to merge these in the
next couple of days.
Cheers,
g.
--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
next reply other threads:[~2008-01-07 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 19:03 Grant Likely [this message]
2008-01-07 19:03 ` [RFC 1/2] mpc5200: Add common clock setting routine mpc52xx_set_psc_clkdiv() Grant Likely
2008-01-08 1:04 ` Stephen Rothwell
2008-01-07 19:07 ` [RFC 2/2] mpc52xx_psc_spi device driver must not touch port_config and cdm Grant Likely
2008-01-10 14:03 ` Dragos Carp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080107185849.13535.38262.stgit@trillian.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=dragos.carp@toptica.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).