linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [RFC 0/2] mpc5200: eliminate direct manipulation of shared registers from SPI driver
@ 2008-01-07 19:03 Grant Likely
  2008-01-07 19:03 ` [RFC 1/2] mpc5200: Add common clock setting routine mpc52xx_set_psc_clkdiv() Grant Likely
  2008-01-07 19:07 ` [RFC 2/2] mpc52xx_psc_spi device driver must not touch port_config and cdm Grant Likely
  0 siblings, 2 replies; 5+ messages in thread
From: Grant Likely @ 2008-01-07 19:03 UTC (permalink / raw)
  To: dragos.carp, linuxppc-dev

The mpc5200 PSC SPI driver driver directly manipulates the port_config
and the CDM registers on the mpc5200 which it should not do.  port_config
should only be manipulated from within the board specific platform code
and the CDM registers are shared between multiple devices.

This patch eliminates the port_config manipulations and adds a common
routine for adjusting CDM settings.  Boards using the SPI driver will
need to add the required port_config changes to either the boot firmware
or the platform code.

If there are no objections, I plan to ask Paulus to merge these in the
next couple of days.

Cheers,
g.

--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-01-10 14:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-07 19:03 [RFC 0/2] mpc5200: eliminate direct manipulation of shared registers from SPI driver Grant Likely
2008-01-07 19:03 ` [RFC 1/2] mpc5200: Add common clock setting routine mpc52xx_set_psc_clkdiv() Grant Likely
2008-01-08  1:04   ` Stephen Rothwell
2008-01-07 19:07 ` [RFC 2/2] mpc52xx_psc_spi device driver must not touch port_config and cdm Grant Likely
2008-01-10 14:03   ` Dragos Carp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).