linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH] MTD for Taco
Date: Wed, 9 Jan 2008 12:42:43 -0600	[thread overview]
Message-ID: <20080109124243.73205d68@zod.rchland.ibm.com> (raw)
In-Reply-To: <47850CEF.9060209@pikatech.com>

On Wed, 09 Jan 2008 13:05:35 -0500
Sean MacLennan <smaclennan@pikatech.com> wrote:

> Stefan Roese wrote:
> > On Saturday 05 January 2008, Sean MacLennan wrote:
> >   
> >> This patch adds the maps for the taco. It also gets the ndfc.c NAND
> >> driver in a compilable state. The map is guaranteed to change since the
> >> exact NOR/NAND flash configuration is in flux right now when we found
> >> the 256M NAND flash won't boot properly.
> >>
> >> Currently it configures the NOR in a reasonable fashion and leaves the
> >> NAND as one honkin' parition.
> >>     
> >
> > <snip>
> >
> >   
> >> diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c
> >> index 1c0e89f..f5e93cf 100644
> >> --- a/drivers/mtd/nand/ndfc.c
> >> +++ b/drivers/mtd/nand/ndfc.c
> >> @@ -24,11 +24,6 @@
> >>  #include <linux/platform_device.h>
> >>  
> >>  #include <asm/io.h>
> >> -#ifdef CONFIG_40x
> >> -#include <asm/ibm405.h>
> >> -#else
> >> -#include <asm/ibm44x.h>
> >> -#endif
> >>     
> >
> > You do break arch/ppc support with this patch. We have to still support
> > arch/ppc a few month, so please don't break this support for now.
> >  
> Here is an updated patch that does not break the ppc arch support. 
> Unfortunately, it still has the taco specific patch. I can't find 
> anything different between the taco and the sequoia and since this patch 
> fixes the problem, the hardware guys refuse to look into it. I can't 
> blame them as we are overloaded as it is.
> 
> But I will send out the patch anyway in case anybody needs the ndfc 
> driver working under the powerpc arch.

This doesn't really get the addresses, etc from the device tree though,
correct?

josh

  reply	other threads:[~2008-01-09 18:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-05  5:17 [PATCH] MTD for Taco Sean MacLennan
2008-01-05  9:41 ` Stefan Roese
2008-01-05 12:25   ` David Gibson
2008-01-06  3:20     ` Sean MacLennan
2008-01-06  3:44       ` David Gibson
2008-01-05 18:20   ` Sean MacLennan
2008-01-05 19:19     ` Arnd Bergmann
2008-01-09 18:05   ` Sean MacLennan
2008-01-09 18:42     ` Josh Boyer [this message]
2008-01-09 18:50       ` Sean MacLennan
2008-01-09 19:04         ` Josh Boyer
2008-01-14  4:55   ` Sean MacLennan
2008-01-14  8:44     ` Josh Boyer
2008-01-14 17:32       ` Sean MacLennan
2008-01-14 19:42         ` Stefan Roese
2008-01-14 20:04           ` Sean MacLennan
2008-01-15  5:15             ` Stefan Roese
2008-01-15  6:30               ` Sean MacLennan
2008-01-15  6:39                 ` Stefan Roese
2008-01-15 18:22                   ` Sean MacLennan
2008-01-16 21:25     ` Sean MacLennan
2008-01-16 23:34       ` Josh Boyer
2008-01-16 23:51         ` Sean MacLennan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080109124243.73205d68@zod.rchland.ibm.com \
    --to=jwboyer@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=smaclennan@pikatech.com \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).