From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Base Warp Platform support
Date: Wed, 9 Jan 2008 13:10:55 -0600 [thread overview]
Message-ID: <20080109131055.7f277528@zod.rchland.ibm.com> (raw)
In-Reply-To: <478504BF.2000908@pikatech.com>
On Wed, 09 Jan 2008 12:30:39 -0500
Sean MacLennan <smaclennan@pikatech.com> wrote:
> So no comments? I got it perfect the first time :D
Not quite.. :)
The way you have the patches laid out right now will break compiling
and git bisecting.
Could you take these and roll them up into distinct patches that can
all apply without breaking a compile individually? I recommend doing
it this way:
Patch 1) platform files in arch/powerpc/platforms/44x/
Patch 2) DTS
Patch 3) boot files in arch/powerpc/boot
Patch 4) defconfig
or something along those lines.
That way we can apply them in that order, nothing breaks for the
compile, and they aren't scattered about. If you start a new email
thread with those I think most of it looked fairly good otherwise.
next prev parent reply other threads:[~2008-01-09 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 4:49 [PATCH] Base Taco Platform support Sean MacLennan
2008-01-05 5:01 ` Sean MacLennan
2008-01-05 7:20 ` Benjamin Herrenschmidt
2008-01-05 18:10 ` Sean MacLennan
2008-01-08 18:58 ` Base Warp " Sean MacLennan
2008-01-09 17:30 ` Sean MacLennan
2008-01-09 18:54 ` [PATCH 3/2] " Sean MacLennan
2008-01-09 19:10 ` Josh Boyer [this message]
2008-01-08 18:59 ` [PATCH 1/2] " Sean MacLennan
2008-01-08 19:01 ` [PATCH 2/2] " Sean MacLennan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080109131055.7f277528@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=smaclennan@pikatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).