[PATCH] enable built-in networking for Sequoia defconfig

[PATCH] enable built-in networking for Sequoia defconfig

[Hollis Blanchard]

Enable EMAC driver for Sequoia (and while we're in there, disable
Macintosh drivers for Sequoia and Bamboo).

Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

diff --git a/arch/powerpc/configs/bamboo_defconfig b/arch/powerpc/configs/bamboo_defconfig
--- a/arch/powerpc/configs/bamboo_defconfig
+++ b/arch/powerpc/configs/bamboo_defconfig
@@ -372,9 +372,7 @@ CONFIG_MISC_DEVICES=y
 # CONFIG_FIREWIRE is not set
 # CONFIG_IEEE1394 is not set
 # CONFIG_I2O is not set
-CONFIG_MACINTOSH_DRIVERS=y
-# CONFIG_MAC_EMUMOUSEBTN is not set
-# CONFIG_WINDFARM is not set
+# CONFIG_MACINTOSH_DRIVERS is not set
 CONFIG_NETDEVICES=y
 # CONFIG_NETDEVICES_MULTIQUEUE is not set
 # CONFIG_DUMMY is not set
diff --git a/arch/powerpc/configs/sequoia_defconfig b/arch/powerpc/configs/sequoia_defconfig
--- a/arch/powerpc/configs/sequoia_defconfig
+++ b/arch/powerpc/configs/sequoia_defconfig
@@ -446,9 +446,7 @@ CONFIG_MISC_DEVICES=y
 # CONFIG_FIREWIRE is not set
 # CONFIG_IEEE1394 is not set
 # CONFIG_I2O is not set
-CONFIG_MACINTOSH_DRIVERS=y
-# CONFIG_MAC_EMUMOUSEBTN is not set
-# CONFIG_WINDFARM is not set
+# CONFIG_MACINTOSH_DRIVERS is not set
 CONFIG_NETDEVICES=y
 # CONFIG_NETDEVICES_MULTIQUEUE is not set
 # CONFIG_DUMMY is not set
@@ -459,10 +457,28 @@ CONFIG_NETDEVICES=y
 # CONFIG_VETH is not set
 # CONFIG_IP1000 is not set
 # CONFIG_ARCNET is not set
-# CONFIG_NET_ETHERNET is not set
+# CONFIG_PHYLIB is not set
+CONFIG_NET_ETHERNET=y
+# CONFIG_MII is not set
+# CONFIG_HAPPYMEAL is not set
+# CONFIG_SUNGEM is not set
+# CONFIG_CASSINI is not set
+# CONFIG_NET_VENDOR_3COM is not set
+# CONFIG_NET_TULIP is not set
+# CONFIG_HP100 is not set
+CONFIG_IBM_NEW_EMAC=y
+CONFIG_IBM_NEW_EMAC_RXB=128
+CONFIG_IBM_NEW_EMAC_TXB=64
+CONFIG_IBM_NEW_EMAC_POLL_WEIGHT=32
+CONFIG_IBM_NEW_EMAC_RX_COPY_THRESHOLD=256
+CONFIG_IBM_NEW_EMAC_RX_SKB_HEADROOM=0
+# CONFIG_IBM_NEW_EMAC_DEBUG is not set
 CONFIG_IBM_NEW_EMAC_ZMII=y
 CONFIG_IBM_NEW_EMAC_RGMII=y
+# CONFIG_IBM_NEW_EMAC_TAH is not set
 CONFIG_IBM_NEW_EMAC_EMAC4=y
+# CONFIG_NET_PCI is not set
+# CONFIG_B44 is not set
 CONFIG_NETDEV_1000=y
 # CONFIG_ACENIC is not set
 # CONFIG_DL2K is not set

Re: [PATCH] enable built-in networking for Sequoia defconfig

[Josh Boyer]

On Fri, 04 Jan 2008 17:26:54 -0600
Hollis Blanchard <hollisb@us.ibm.com> wrote:

> Enable EMAC driver for Sequoia (and while we're in there, disable
> Macintosh drivers for Sequoia and Bamboo).
> 
> Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

applied, thanks.

josh

Re: [PATCH] enable built-in networking for Sequoia defconfig

[Matthias Fuchs]

Josh, 

Where did you apply this patch to? Couldn't find it in your for-2.6.25 branch.

BTW, is it normal to edit the defconfig file by hand?
I cannot get CONFIG_IBM_NEW_EMAC enabled through Kconfig. Am I missing something:
	
	a) Patch to enable IBM_NEW_EMAC via Kconfig is welcome
	b) Matthias only knows only half the truth.

Matthias


On Tuesday 08 January 2008 17:09, Josh Boyer wrote:
> On Fri, 04 Jan 2008 17:26:54 -0600
> Hollis Blanchard <hollisb@us.ibm.com> wrote:
> 
> > Enable EMAC driver for Sequoia (and while we're in there, disable
> > Macintosh drivers for Sequoia and Bamboo).
> > 
> > Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> 
> applied, thanks.
> 
> josh
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
> 
> 

Re: [PATCH] enable built-in networking for Sequoia defconfig

[Josh Boyer]

On Wed, 9 Jan 2008 12:16:25 +0100
Matthias Fuchs <matthias.fuchs@esd-electronics.com> wrote:

> Josh, 
> 
> Where did you apply this patch to? Couldn't find it in your for-2.6.25 branch.

I applied it there, just haven't pushed it out yet.  Will do that today.

> BTW, is it normal to edit the defconfig file by hand?

The defconfig?  Not sure.  What I normally do is a make foo_defconfig,
edit the .config, make oldconfig, and copy the resulting .config back
to foo_defconfig.

josh

Re: [PATCH] enable built-in networking for Sequoia defconfig

[Matthias Fuchs]

On Wednesday 09 January 2008 13:07, Josh Boyer wrote:
> On Wed, 9 Jan 2008 12:16:25 +0100
> Matthias Fuchs <matthias.fuchs@esd-electronics.com> wrote:
> 
> > Josh, 
> > 
> > Where did you apply this patch to? Couldn't find it in your for-2.6.25 branch.
> 
> I applied it there, just haven't pushed it out yet.  Will do that today.
> 
> > BTW, is it normal to edit the defconfig file by hand?
> 
> The defconfig?  Not sure.  What I normally do is a make foo_defconfig,
> edit the .config, make oldconfig, and copy the resulting .config back
> to foo_defconfig.
Yes, this is what I also do.

But how did Hollis get these lines into .config or sequoia_defconfig:

+CONFIG_IBM_NEW_EMAC=y
+CONFIG_IBM_NEW_EMAC_RXB=128
+CONFIG_IBM_NEW_EMAC_TXB=64
+CONFIG_IBM_NEW_EMAC_POLL_WEIGHT=32
+CONFIG_IBM_NEW_EMAC_RX_COPY_THRESHOLD=256
+CONFIG_IBM_NEW_EMAC_RX_SKB_HEADROOM=0

I did not find any Kconfigs where these might come from.

Any hint?

Matthias

Re: [PATCH] enable built-in networking for Sequoia defconfig

[Stefan Roese]

On Wednesday 09 January 2008, Matthias Fuchs wrote:
> > The defconfig?  Not sure.  What I normally do is a make foo_defconfig,
> > edit the .config, make oldconfig, and copy the resulting .config back
> > to foo_defconfig.
>
> Yes, this is what I also do.
>
> But how did Hollis get these lines into .config or sequoia_defconfig:
>
> +CONFIG_IBM_NEW_EMAC=3Dy
> +CONFIG_IBM_NEW_EMAC_RXB=3D128
> +CONFIG_IBM_NEW_EMAC_TXB=3D64
> +CONFIG_IBM_NEW_EMAC_POLL_WEIGHT=3D32
> +CONFIG_IBM_NEW_EMAC_RX_COPY_THRESHOLD=3D256
> +CONFIG_IBM_NEW_EMAC_RX_SKB_HEADROOM=3D0
>
> I did not find any Kconfigs where these might come from.

Take a look at drivers/net/ibm_newemac/Kconfig.

Viele Gr=FC=DFe,
Stefan

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

Re: [PATCH] enable built-in networking for Sequoia defconfig

[Josh Boyer]

On Wed, 9 Jan 2008 15:42:38 +0100
Matthias Fuchs <matthias.fuchs@esd-electronics.com> wrote:

> On Wednesday 09 January 2008 13:07, Josh Boyer wrote:
> > On Wed, 9 Jan 2008 12:16:25 +0100
> > Matthias Fuchs <matthias.fuchs@esd-electronics.com> wrote:
> > 
> > > Josh, 
> > > 
> > > Where did you apply this patch to? Couldn't find it in your for-2.6.25 branch.
> > 
> > I applied it there, just haven't pushed it out yet.  Will do that today.
> > 
> > > BTW, is it normal to edit the defconfig file by hand?
> > 
> > The defconfig?  Not sure.  What I normally do is a make foo_defconfig,
> > edit the .config, make oldconfig, and copy the resulting .config back
> > to foo_defconfig.
> Yes, this is what I also do.
> 
> But how did Hollis get these lines into .config or sequoia_defconfig:
> 
> +CONFIG_IBM_NEW_EMAC=y
> +CONFIG_IBM_NEW_EMAC_RXB=128
> +CONFIG_IBM_NEW_EMAC_TXB=64
> +CONFIG_IBM_NEW_EMAC_POLL_WEIGHT=32
> +CONFIG_IBM_NEW_EMAC_RX_COPY_THRESHOLD=256
> +CONFIG_IBM_NEW_EMAC_RX_SKB_HEADROOM=0
> 
> I did not find any Kconfigs where these might come from.

They're in drivers/net/ibm_newemac/Kconfig.

josh

Re: [PATCH] enable built-in networking for Sequoia defconfig

[Matthias Fuchs]

Thanks,

Sorry, I must have been blind.

Matthias

On Wednesday 09 January 2008 16:21, Josh Boyer wrote:
> On Wed, 9 Jan 2008 15:42:38 +0100
> Matthias Fuchs <matthias.fuchs@esd-electronics.com> wrote:
> 
> > On Wednesday 09 January 2008 13:07, Josh Boyer wrote:
> > > On Wed, 9 Jan 2008 12:16:25 +0100
> > > Matthias Fuchs <matthias.fuchs@esd-electronics.com> wrote:
> > > 
> > > > Josh, 
> > > > 
> > > > Where did you apply this patch to? Couldn't find it in your for-2.6.25 branch.
> > > 
> > > I applied it there, just haven't pushed it out yet.  Will do that today.
> > > 
> > > > BTW, is it normal to edit the defconfig file by hand?
> > > 
> > > The defconfig?  Not sure.  What I normally do is a make foo_defconfig,
> > > edit the .config, make oldconfig, and copy the resulting .config back
> > > to foo_defconfig.
> > Yes, this is what I also do.
> > 
> > But how did Hollis get these lines into .config or sequoia_defconfig:
> > 
> > +CONFIG_IBM_NEW_EMAC=y
> > +CONFIG_IBM_NEW_EMAC_RXB=128
> > +CONFIG_IBM_NEW_EMAC_TXB=64
> > +CONFIG_IBM_NEW_EMAC_POLL_WEIGHT=32
> > +CONFIG_IBM_NEW_EMAC_RX_COPY_THRESHOLD=256
> > +CONFIG_IBM_NEW_EMAC_RX_SKB_HEADROOM=0
> > 
> > I did not find any Kconfigs where these might come from.
> 
> They're in drivers/net/ibm_newemac/Kconfig.
> 
> josh
> 
>