From: David Gibson <david@gibson.dropbear.id.au>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, Li Yang <leoli@freescale.com>, paulus@samba.org
Subject: Re: [PATCH 1/3] add default device trees for MPC837x MDS board
Date: Thu, 10 Jan 2008 10:42:16 +1100 [thread overview]
Message-ID: <20080109234215.GA17153@localhost.localdomain> (raw)
In-Reply-To: <fa686aa40801080758o35dce96ej5db45576769561a5@mail.gmail.com>
On Tue, Jan 08, 2008 at 08:58:17AM -0700, Grant Likely wrote:
> Hi Leo,
>
> comments below. I've made my comments on the first file, but they
> apply to the other two also.
>
> Cheers,
> g.
[snip]
> > + ranges = <0 e0000000 00100000>;
> > + reg = <e0000000 00000200>;
> > + bus-frequency = <0>;
> > +
> > + wdt@200 {
> > + compatible = "mpc83xx_wdt";
>
> "fsl,mpc8377_wdt", "fsl,mpc83xx_wdt" as per generic names recommended practice.
Uh.. that's reasonable advice, but it has nothing to do with the
generic names recommended practice.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2008-01-09 23:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 12:03 [PATCH 1/3] add default device trees for MPC837x MDS board Li Yang
2008-01-07 12:03 ` [PATCH 2/3] add MPC837x USB platform support Li Yang
2008-01-07 12:03 ` [PATCH 3/3] USB device tree cleanups Li Yang
2008-01-07 23:10 ` Stephen Rothwell
2008-01-08 3:32 ` Li Yang
2008-01-07 23:05 ` [PATCH 2/3] add MPC837x USB platform support Stephen Rothwell
2008-01-08 7:36 ` [PATCH 1/3] add default device trees for MPC837x MDS board Kumar Gala
2008-01-08 7:57 ` Li Yang
2008-01-08 15:18 ` Kumar Gala
2008-01-08 15:58 ` Grant Likely
2008-01-08 17:38 ` Scott Wood
2008-01-08 17:53 ` Grant Likely
2008-01-09 8:38 ` Li Yang
2008-01-09 23:42 ` David Gibson [this message]
2008-01-10 0:59 ` Grant Likely
2008-01-18 6:31 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080109234215.GA17153@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=grant.likely@secretlab.ca \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).