From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lixom.net (lixom.net [66.141.50.11]) by ozlabs.org (Postfix) with ESMTP id 1D4EADE017 for ; Thu, 10 Jan 2008 11:27:06 +1100 (EST) Date: Wed, 9 Jan 2008 18:36:34 -0600 From: Olof Johansson To: Stephen Rothwell Subject: Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver Message-ID: <20080110003634.GA19966@lixom.net> References: <20080109190852.GA18827@localhost.localdomain> <20080109191041.GB23283@localhost.localdomain> <20080110104048.2fea6ab3.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20080110104048.2fea6ab3.sfr@canb.auug.org.au> Cc: Paul Mundt , linuxppc-dev@ozlabs.org, Jeff Garzik , linux-ide@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jan 10, 2008 at 10:40:48AM +1100, Stephen Rothwell wrote: > Hi Anton, > > Juts one small trivial comment (could be fixed later). > > On Wed, 9 Jan 2008 22:10:41 +0300 Anton Vorontsov wrote: > > > > +static struct of_device_id pata_of_platform_match[] = { > > This could be declared const. Good point, but let's not hold up merge based on this. Need something for janitors to do too, and it's good enough to merge as-is. :) -Olof