From: Yuri Tikhonov <yur@emcraft.com>
To: Eugene Surovegin <ebs@ebshome.net>
Cc: linuxppc-dev@ozlabs.org, sr@denx.de, dzu@denx.de
Subject: Re: [PATCH 0/2] [PPC 4xx] L2-cache synchronization for ppc44x
Date: Fri, 11 Jan 2008 18:24:46 +0300 [thread overview]
Message-ID: <200801111824.46920.yur@emcraft.com> (raw)
In-Reply-To: <20071128195037.GB22325@gate.ebshome.net>
Hello, Eugene,
The h/w snooping mechanism you are talking about is limited to the Low
Latency (LL) segment of the PLB bus in ppc440sp and ppc440spe chips (see
section "7.2.7 L2 Cache Coherency" of the ppc440spe spec), whereas DMA and
XOR engines use the High Bandwidth (HB) segment of PLB bus (see
section "1.1.2 Internal Buses" of the ppc440spe spec).
Thus, the h/w snooping mechanism is not able to trace the results of
operations performed by DMA and XOR engines and keep L2-cache coherent with
SDRAM, because the data flow through the HB PLB segment. This leads to, for
example, incorrect results of RAID-parity calculations if one uses the h/w
accelerated ppc440spe ADMA driver with L2-cache enabled.
The s/w synchronization algorithms proposed in my patches has no LL PLB
limitations as opposed to h/w snooping, but, probably, this is not the best
way of how it might be implemented. Even though with these patches the h/w
accelerated RAID starts to operate correctly (with L2-cache enabled) there is
a performance degradation (induced by loops in the L2-cache synchronization
routines) observed in the most cases. So, as a result, there is no benefit
from using L2-cache for these, RAID, cases at all.
Regards, Yuri
On Wednesday 28 November 2007 22:50, Eugene Surovegin wrote:
> On Wed, Nov 07, 2007 at 01:40:10AM +0300, Yuri Tikhonov wrote:
> >
> > Hello all,
> >
> > Here is a patch-set for support L2-cache synchronization routines for
> > the ppc44x processors family. I know that the "ppc" branch is for
bug-fixing only, thus
> > the patch-set is just FYI [though enabled but non-coherent L2-cache may
appear as a bug for
> > someone who uses one of the boards listed below :)].
> >
> > [PATCH 1/2] [PPC 4xx] invalidate_l2cache_range() implementation for
ppc44x;
> > [PATCH 2/2] [PPC 44x] enable L2-cache for the following ppc44x-based
boards: ALPR,
> > Katmai, Ocotea, and Taishan.
>
> Why is this all needed?
>
> IIRC ibm440gx_l2c_enable() configures 64G snoop region for L2C.
>
> Did AMCC made non-only-coherent L2C chips recently?
>
> --
> Eugene
>
>
--
Yuri Tikhonov, Senior Software Engineer
Emcraft Systems, www.emcraft.com
next prev parent reply other threads:[~2008-01-11 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 22:40 [PATCH 0/2] [PPC 4xx] L2-cache synchronization for ppc44x Yuri Tikhonov
2007-11-28 19:50 ` Eugene Surovegin
2008-01-11 15:24 ` Yuri Tikhonov [this message]
2008-01-11 17:41 ` Eugene Surovegin
2008-01-11 22:05 ` Benjamin Herrenschmidt
2008-01-11 22:38 ` Eugene Surovegin
2008-01-12 1:52 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801111824.46920.yur@emcraft.com \
--to=yur@emcraft.com \
--cc=dzu@denx.de \
--cc=ebs@ebshome.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).