From: David Gibson <david@gibson.dropbear.id.au>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/2] [POWERPC] 4xx: Add AMCC Haleakala (405EXr) dts
Date: Wed, 16 Jan 2008 16:52:43 +1100 [thread overview]
Message-ID: <20080116055243.GC5016@localhost.localdomain> (raw)
In-Reply-To: <200801160604.56766.sr@denx.de>
On Wed, Jan 16, 2008 at 06:04:56AM +0100, Stefan Roese wrote:
> On Wednesday 16 January 2008, David Gibson wrote:
> > On Tue, Jan 15, 2008 at 08:09:25AM +0100, Stefan Roese wrote:
[snip]
> > > + RGMII0: emac-rgmii@ef600b00 {
> > > + device_type = "rgmii-interface";
> >
> > And especially not here.
>
> Ok.
>
> Your comments are valid for some of the other 4xx dts files too. Should I
> create a patch that removes these device-types there too?
Yes please :).
[snip]
> > Oh, for crying out loud. They put dcrs on the bridge as well as MMIO
> > registers. *facepalm*
>
> Yep. PCIe on 4xx has DCR, SDR *and* MMIO registers.
Ungh.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2008-01-16 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 7:09 [PATCH 2/2] [POWERPC] 4xx: Add AMCC Haleakala (405EXr) dts Stefan Roese
2008-01-16 0:46 ` David Gibson
2008-01-16 5:04 ` Stefan Roese
2008-01-16 5:52 ` David Gibson [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-16 7:24 Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080116055243.GC5016@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).