[MPC5200] problem running FEC and ATA

[MPC5200] problem running FEC and ATA

[Arnon Kaufman]

does any one succeed running a functional FEC and ATA (pata) running 
together ?
If so which version (2.6.x...) and with which architecture (powerpc or 
ppc)?.

The machine I'm working on based on v2.6.21-rc6 and another one based on 
v2.6.24-rc1, both configured with ARCH=powerpc.

my FEC introduce itself as: "PHY: f0003000:01", and not as f0003000:00, 
I've fix it by adjusting the dts file, is that ok?

I'm getting the following, when pinging the machine:

64 bytes from xxx.xxx.xxx.xxx: icmp_seq=4401 ttl=64 time=0.249 ms
64 bytes from xxx.xxx.xxx.xxx: icmp_seq=4402 ttl=64 time=0.285 ms
wrong data byte #52 should be 0x34 but was 0xa
#8      8 9 a b c d e f 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f 
20 21 22 23 24 25 26 27
#40     28 29 2a 2b 2c 2d 2e 2f 30 31 32 33 a 35 36 37
64 bytes from xxx.xxx.xxx.xxx: icmp_seq=4403 ttl=64 time=0.233 ms
wrong data byte #20 should be 0x14 but was 0x0
#8      8 9 a b c d e f 10 11 12 13 0 15 16 17 18 19 1a 1b 1c 1d 1e 1f 
20 21 22 23 24 25 26 27
#40     28 29 2a 2b 2c 2d 2e 2f 30 31 32 33 34 35 36 37
64 bytes from xxx.xxx.xxx.xxx: icmp_seq=4404 ttl=64 time=0.232 ms
64 bytes from xxx.xxx.xxx.xxx: icmp_seq=4405 ttl=64 time=0.237 ms

-----

The offsets and values of the corrupted data are constant (can it be the 
  microcode?)

when enabling the PATA driver and doing some Compact flash access 
operation the amount of packets corruption is getting worse.

does the pata driver needs to wait on the TIP indicator? cause it 
doesn't seems to do it.

Re: [MPC5200] problem running FEC and ATA

[Robert Schwebel]

On Sun, Dec 16, 2007 at 03:24:34PM +0200, Arnon Kaufman wrote:
> does any one succeed running a functional FEC and ATA (pata) running
> together?

Yes, we do, on the phyCORE-MPC5200B-tiny; you can check our patches here:
http://www.pengutronix.de/oselas/bsp/phytec/download/phyCORE-MPC5200B-tiny/

We've recently made the -6 release which supports ATA; although I'm not
sure if the tests were done with networking & ATA at the same time I
assume yes (at least while doing nfsroot). We'll re-check your scenario.

Note that there has been quite some activity wrt. MPC5200, bestcom and
fec in the mainline recently. You should test the latest 2.6.24-rc
kernel.

Robert
-- 
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

Re: [MPC5200] problem running FEC and ATA

[Arnon Kaufman]

Robert Schwebel wrote:
> On Sun, Dec 16, 2007 at 03:24:34PM +0200, Arnon Kaufman wrote:
>> does any one succeed running a functional FEC and ATA (pata) running
>> together?
> 
> Yes, we do, on the phyCORE-MPC5200B-tiny; you can check our patches here:
> http://www.pengutronix.de/oselas/bsp/phytec/download/phyCORE-MPC5200B-tiny/
>

thanks, my kernels are already patched and still observing that kind of 
behavior. I'm using Domen's new FEC code and ATA from 2.6.24-rc2.

playing with the XLB Master's enable and priority lead to significant 
changes (good ones) in the rate of corruption appearance. I'm afraid of 
the "new" priority I've set, as that may lead to lockups on the XLB, 
still investigating.


> We've recently made the -6 release which supports ATA; although I'm not
> sure if the tests were done with networking & ATA at the same time I
> assume yes (at least while doing nfsroot). We'll re-check your scenario.
> 
> Note that there has been quite some activity wrt. MPC5200, bestcom and
> fec in the mainline recently. You should test the latest 2.6.24-rc
> kernel.
> 
> Robert

Re: [MPC5200] problem running FEC and ATA

[Robert Schwebel]

On Sun, Dec 16, 2007 at 07:28:40PM +0200, Arnon Kaufman wrote:
> Robert Schwebel wrote:
> >On Sun, Dec 16, 2007 at 03:24:34PM +0200, Arnon Kaufman wrote:
> >>does any one succeed running a functional FEC and ATA (pata) running
> >>together?
> >
> >Yes, we do, on the phyCORE-MPC5200B-tiny; you can check our patches here:
> >http://www.pengutronix.de/oselas/bsp/phytec/download/phyCORE-MPC5200B-tiny/
>
> thanks, my kernels are already patched and still observing that kind of
> behavior. I'm using Domen's new FEC code and ATA from 2.6.24-rc2.
>
> playing with the XLB Master's enable and priority lead to significant
> changes (good ones) in the rate of corruption appearance. I'm afraid of
> the "new" priority I've set, as that may lead to lockups on the XLB,
> still investigating.

Do you have a reproducable test scenario we can try on our hardware?

Robert
-- 
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

Re: [MPC5200] problem running FEC and ATA

[Juergen Beisert]

On Sunday 16 December 2007 18:28, Arnon Kaufman wrote:
> Robert Schwebel wrote:
>> On Sun, Dec 16, 2007 at 03:24:34PM +0200, Arnon Kaufman wrote:
>>> does any one succeed running a functional FEC and ATA (pata) running
>>> together?
>>
>> Yes, we do, on the phyCORE-MPC5200B-tiny; you can check our patches here:
>> http://www.pengutronix.de/oselas/bsp/phytec/download/phyCORE-MPC5200B-ti=
ny/
>
> thanks, my kernels are already patched and still observing that kind of
> behavior. I'm using Domen's new FEC code and ATA from 2.6.24-rc2.

I tried our kernel (see link above) with an external harddisk and NFS. I=20
copied various files from the harddisk to NFS root and vice versa. No data=
=20
corruption.

Can you check our patch stack on your hardware?

Juergen
=2D-=20
Dipl.-Ing. Juergen Beisert | http://www.pengutronix.de
=A0Pengutronix - Linux Solutions for Science and Industry
=A0   Handelsregister: Amtsgericht Hildesheim, HRA 2686
=A0 =A0 =A0    Vertretung Sued/Muenchen, Germany
   Phone: +49-8766-939 228 |  Fax: +49-5121-206917-9

Re: [MPC5200] problem running FEC and ATA

[Mehlan, Markus (Ritter Elektronik)]

Hello all,

i have the same problem with the fec driver. See my posting
at
http://ozlabs.org/pipermail/linuxppc-embedded/2008-January/029466.html

Arnon, have you already fixed the FEC problem?

Thanks and regards,
Markus.

Re: [MPC5200] problem running FEC and ATA

[Juergen Beisert]

Markus,

On Monday 21 January 2008 08:10, Mehlan, Markus (Ritter Elektronik) wrote:
> i have the same problem with the fec driver. See my posting
> at
> http://ozlabs.org/pipermail/linuxppc-embedded/2008-January/029466.html
>
> Arnon, have you already fixed the FEC problem?

Can you check this?

http://ozlabs.org/pipermail/linuxppc-embedded/2007-May/027046.html

Regards,
Juergen
=2D-=20
Dipl.-Ing. Juergen Beisert | http://www.pengutronix.de
=A0Pengutronix - Linux Solutions for Science and Industry
=A0   Handelsregister: Amtsgericht Hildesheim, HRA 2686
=A0 =A0 =A0    Vertretung Sued/Muenchen, Germany
   Phone: +49-8766-939 228 |  Fax: +49-5121-206917-9

Re: [MPC5200] problem running FEC and ATA

[Mehlan, Markus (Ritter Elektronik)]

 Hello Juergen,

> -----Urspr=FCngliche Nachricht-----
> Von: Juergen Beisert [mailto:jbe@pengutronix.de]=20
> Gesendet: Montag, 21. Januar 2008 09:58
> An: linuxppc-dev@ozlabs.org
> Cc: Mehlan, Markus (Ritter Elektronik)
> Betreff: Re: [MPC5200] problem running FEC and ATA
>=20
> Markus,
>=20
> On Monday 21 January 2008 08:10, Mehlan, Markus (Ritter=20
> Elektronik) wrote:
> > i have the same problem with the fec driver. See my posting at=20
> >=20
> http://ozlabs.org/pipermail/linuxppc-embedded/2008-January/029466.html
> >
> > Arnon, have you already fixed the FEC problem?
>=20
> Can you check this?
>=20
> http://ozlabs.org/pipermail/linuxppc-embedded/2007-May/027046.html

I have checked the article. To set the BSDIS bit in the XLB config =
register
during initialization fixes my problem:

xlb =3D (struct mpc52xx_xlb *)MPC5xxx_XLB;
out_be32(&xlb->config,  in_be32(&xlb->config) |
MPC52xx_XLB_CFG_BSDIS);

Thank you!

Best regards,
Markus

Re: [MPC5200] problem running FEC and ATA

[Juergen Beisert]

On Monday 21 January 2008 14:01, Mehlan, Markus (Ritter Elektronik) wrote:
> > -----Urspr=FCngliche Nachricht-----
> > Von: Juergen Beisert [mailto:jbe@pengutronix.de]
> > Gesendet: Montag, 21. Januar 2008 09:58
> > An: linuxppc-dev@ozlabs.org
> > Cc: Mehlan, Markus (Ritter Elektronik)
> > Betreff: Re: [MPC5200] problem running FEC and ATA
> >
> > Markus,
> >
> > On Monday 21 January 2008 08:10, Mehlan, Markus (Ritter
> >
> > Elektronik) wrote:
> > > i have the same problem with the fec driver. See my posting at
> >
> > http://ozlabs.org/pipermail/linuxppc-embedded/2008-January/029466.html
> >
> > > Arnon, have you already fixed the FEC problem?
> >
> > Can you check this?
> >
> > http://ozlabs.org/pipermail/linuxppc-embedded/2007-May/027046.html
>
> I have checked the article. To set the BSDIS bit in the XLB config regist=
er
> during initialization fixes my problem:
>
> xlb =3D (struct mpc52xx_xlb *)MPC5xxx_XLB;
> out_be32(&xlb->config,  in_be32(&xlb->config) |
> MPC52xx_XLB_CFG_BSDIS);

Is anybody out there with more MPC5200B experience? Can someone tell me why=
=20
some MPC5200B are need this patch and others not? We have two different=20
systems here (cards from different vendors) with the same processor, one=20
needs this BSDIS-patch and the other not. ???????????????

Juergen

=2D-=20
Dipl.-Ing. Juergen Beisert | http://www.pengutronix.de
=A0Pengutronix - Linux Solutions for Science and Industry
=A0   Handelsregister: Amtsgericht Hildesheim, HRA 2686
=A0 =A0 =A0    Vertretung Sued/Muenchen, Germany
   Phone: +49-8766-939 228 |  Fax: +49-5121-206917-9

Re: [MPC5200] problem running FEC and ATA

[Wolfgang Denk]

In message <200801211728.22817.jbe@pengutronix.de> you wrote:
>
> Is anybody out there with more MPC5200B experience? Can someone tell me why
> some MPC5200B are need this patch and others not? We have two different
> systems here (cards from different vendors) with the same processor, one
> needs this BSDIS-patch and the other not. ???????????????

Is it really exactly the same CPU revision? My guess is that one is
rev. B and the other one is older...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
It would be illogical to assume that all conditions remain stable
	-- Spock, "The Enterprise" Incident", stardate 5027.3

Re: [MPC5200] problem running FEC and ATA

[Mehlan, Markus (Ritter Elektronik)]

Hello Wolfgang,

> -----Urspr=FCngliche Nachricht-----
> Von: wd@denx.de [mailto:wd@denx.de]=20
> Gesendet: Mittwoch, 23. Januar 2008 01:21
> An: Juergen Beisert
> Cc: linuxppc-dev@ozlabs.org; Mehlan, Markus (Ritter Elektronik)
> Betreff: Re: [MPC5200] problem running FEC and ATA
>=20
> In message <200801211728.22817.jbe@pengutronix.de> you wrote:
> >
> > Is anybody out there with more MPC5200B experience? Can=20
> someone tell=20
> > me why some MPC5200B are need this patch and others not? We=20
> have two=20
> > different systems here (cards from different vendors) with the same=20
> > processor, one needs this BSDIS-patch and the other not.=20
> ???????????????
>=20
> Is it really exactly the same CPU revision? My guess is that=20
> one is rev. B and the other one is older...
>=20
The processor on my board which needs the BSDIS-patch has following
label:

MPC5200CVR400B
M62C
REV 1
QAZ0637J

Best regards,
Markus

Re: [MPC5200] problem running FEC and ATA

[Juergen Beisert]

Wolfgang,

On Wednesday 23 January 2008 01:20, Wolfgang Denk wrote:
> In message <200801211728.22817.jbe@pengutronix.de> you wrote:
> > Is anybody out there with more MPC5200B experience? Can someone tell me
> > why some MPC5200B are need this patch and others not? We have two
> > different systems here (cards from different vendors) with the same
> > processor, one needs this BSDIS-patch and the other not. ???????????????
>
> Is it really exactly the same CPU revision? My guess is that one is
> rev. B and the other one is older...

The one who needs this patch (CPU card vendor 1):

MPC5200CVR400B, M62C REV 1, QCW0723T

The CPUs who do not need this patch (CPU card vendor 2):

SPC5200CBV400B, M62C REV 1, QAG0610C
MPC5200CVR400B, M62C REV 1, QAJ0613F


Best regards
Juergen Beisert

=2D-=20
Dipl.-Ing. Juergen Beisert | http://www.pengutronix.de
=A0Pengutronix - Linux Solutions for Science and Industry
=A0   Handelsregister: Amtsgericht Hildesheim, HRA 2686
=A0 =A0 =A0    Vertretung Sued/Muenchen, Germany
   Phone: +49-8766-939 228 |  Fax: +49-5121-206917-9

Re: [MPC5200] problem running FEC and ATA

[Wolfgang Denk]

In message <FACFFB02D783C64FB2CEF2D6825F6FC206EEF1CF@SRVEXC01.sts.saurer.vpn> you wrote:
> 
> > Is it really exactly the same CPU revision? My guess is that
> > one is rev. B and the other one is older...
> 
> The processor on my board which needs the BSDIS-patch has following
> label:
> MPC5200CVR400B

And the one which doesn't need it is a ...?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
I'd rather be led to hell than managed to heaven.

Re: [MPC5200] problem running FEC and ATA

[Wolfgang Denk]

In message <200801231003.15045.jbe@pengutronix.de> you wrote:
> 
> The one who needs this patch (CPU card vendor 1):
> 
> MPC5200CVR400B, M62C REV 1, QCW0723T
> 
> The CPUs who do not need this patch (CPU card vendor 2):
> 
> SPC5200CBV400B, M62C REV 1, QAG0610C
> MPC5200CVR400B, M62C REV 1, QAJ0613F

This is all Rev. B stuff, and the patch should be applied  to  all  of
them (actually the patch can always be applied - it will be activated
depending on the PVR reading).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
It is impractical for  the  standard  to  attempt  to  constrain  the
behavior  of code that does not obey the constraints of the standard.
                                                          - Doug Gwyn