From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Wei.Zhang@freescale.com
Subject: Re: [PATCH] [POWERPC] Move RapidIO support code from arch/ppc
Date: Thu, 24 Jan 2008 09:40:17 +1100 [thread overview]
Message-ID: <20080124094017.8afc5077.sfr@canb.auug.org.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0801230637510.4478@blarg.am.freescale.net>
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
Hi Kumar,
On Wed, 23 Jan 2008 06:38:29 -0600 (CST) Kumar Gala <galak@kernel.crashing.org> wrote:
>
> +++ b/arch/ppc/platforms/85xx/mpc85xx_ads_common.c
> @@ -190,6 +188,7 @@ mpc85xx_exclude_device(u_char bus, u_char devfn)
> #endif /* CONFIG_PCI */
>
> #ifdef CONFIG_RAPIDIO
> +extern void mpc85xx_rio_setup(int law_start, int law_size);
Ooops! This should be in a header file, of course.
> +++ b/arch/ppc/platforms/85xx/stx_gp3.c
> @@ -270,6 +269,7 @@ int mpc85xx_exclude_device(u_char bus, u_char devfn)
> #endif /* CONFIG_PCI */
>
> #ifdef CONFIG_RAPIDIO
> +extern void mpc85xx_rio_setup(int law_start, int law_size);
And again.
I guess this is just temporary in which case we can probably live with
it. But do not forget to fix it up.
> +++ b/arch/ppc/platforms/85xx/tqm85xx.c
> @@ -309,6 +308,7 @@ int mpc85xx_exclude_device(u_char bus, u_char devfn)
> #endif /* CONFIG_PCI */
>
> #ifdef CONFIG_RAPIDIO
> +extern void mpc85xx_rio_setup(int law_start, int law_size);
Third time lucky? :-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-01-23 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 12:38 [PATCH] [POWERPC] Move RapidIO support code from arch/ppc Kumar Gala
2008-01-23 22:40 ` Stephen Rothwell [this message]
2008-01-23 23:00 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080124094017.8afc5077.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=Wei.Zhang@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox