Re: [PATCH] [POWERPC] 85xx: Port STX GP3 board over from arch/ppc

[Scott Wood <scottwood@freescale.com>]

On Thu, Jan 24, 2008 at 12:43:38AM -0600, Kumar Gala wrote:
> +			d-cache-size = <0x8000>;	// L1, 32K
> +			i-cache-size = <0x8000>;	// L1, 32K
> +			timebase-frequency = <0x4ead9a0>;
> +			bus-frequency = <0x13ab6680>;
> +			clock-frequency = <0x312c8040>;

Decimal, please.

> +	soc8560@fdf00000 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		device_type = "soc";
> +		ranges = <0 0xfdf00000 0x100000>;
> +		reg = <0xfdf00000 0x1000>;

compatible = "fsl,mpc8560-immr", "simple-bus".
Also add "simple-bus" to the CPM node.

> +		bus-frequency = <0x13ab6680>;

Decimal, please -- if it needs to exist at all.

> @@ -49,7 +57,7 @@ config MPC8540
>  config MPC8560
>  	bool
>  	select CPM2
> -	default y if MPC8560_ADS
> +	default y if MPC8560_ADS || STX_GP3

Can we select this from 8560 boards, instead of a default y list?

> +static struct of_device_id __initdata of_bus_ids[] = {
> +	{ .name = "soc", },
> +	{ .type = "soc", },
> +	{ .name = "cpm", },
> +	{ .name = "localbus", },
> +	{},
> +};

compatible = "simple-bus".

> +/*
> + * Called very early, device-tree isn't unflattened
> + */
> +static int __init stx_gp3_probe(void)
> +{
> +        unsigned long root = of_get_flat_dt_root();
> +
> +        return of_flat_dt_is_compatible(root, "stx,gp3-8560");
> +}

Tabs, not spaces.

-Scott