From: Scott Wood <scottwood@freescale.com>
To: Heiko Schocher <hs@denx.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/4] 82xx: MGCOGE support
Date: Tue, 29 Jan 2008 13:31:38 -0600 [thread overview]
Message-ID: <20080129193138.GA4304@loki.buserror.net> (raw)
In-Reply-To: <20080129192454.GC4051@loki.buserror.net>
On Tue, Jan 29, 2008 at 01:24:54PM -0600, Scott Wood wrote:
> On Tue, Jan 29, 2008 at 11:22:55AM +0100, Heiko Schocher wrote:
> > + *pram_base = res.start;
>
> First of all, use out_be32() rather than direct dereferencing.
Err, I meant out_be16() of course. :-P
-Scott
next prev parent reply other threads:[~2008-01-29 19:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.813.1200609119.6908.linuxppc-dev@ozlabs.org>
2008-01-29 10:20 ` [PATCH 1/4] 82xx: MGCOGE support Heiko Schocher
2008-01-29 10:21 ` [PATCH 2/4] " Heiko Schocher
2008-01-29 10:22 ` [PATCH 3/4] " Heiko Schocher
2008-01-29 19:20 ` Scott Wood
2008-01-29 19:26 ` Jon Loeliger
2008-01-29 10:22 ` [PATCH 4/4] " Heiko Schocher
2008-01-29 19:24 ` Scott Wood
2008-01-29 19:31 ` Scott Wood [this message]
2008-01-30 9:49 ` [PATCH v2] " Heiko Schocher
2008-02-01 20:45 ` Scott Wood
2008-03-07 13:12 ` Heiko Schocher
2008-03-07 14:55 ` Kumar Gala
2008-03-09 9:53 ` [PATCH v3] " Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129193138.GA4304@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=hs@denx.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).