linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: sparclinux@vger.kernel.org, linux-ia64@vger.kernel.org,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	Mike Travis <travis@sgi.com>,
	Linux/PPC Development <linuxppc-dev@ozlabs.org>,
	Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
Date: Wed, 30 Jan 2008 20:05:27 +0100	[thread overview]
Message-ID: <20080130190527.GA3681@elte.hu> (raw)
In-Reply-To: <20080130184920.GA32212@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> > Uni-processor build still fails with this patch (config is 
> > arch/ia64/configs/tiger_defconfig with CONFIG_SMP switched from =y 
> > to =n).
> 
> could you try the full patchset that Travis has just sent and which 
> i've put into x86.git, you can pull it from:

btw., i needed the fix below to get DISCONTIGMEM + !NUMA to build. (this 
is an ia64 build breakage independent of the x86.git merge)

	Ingo

-------------->
Subject: ia64: build fix
From: Ingo Molnar <mingo@elte.hu>

DISCONTIGMEM does not build with NUMA disabled:

include/linux/gfp.h: In function `alloc_pages_node':
include/linux/gfp.h:189: error: implicit declaration of function `NODE_DATA'
include/linux/gfp.h:189: error: invalid type argument of `->'
In file included from include/asm/uaccess.h:39,

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/ia64/Kconfig |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux-x86.q/arch/ia64/Kconfig
===================================================================
--- linux-x86.q.orig/arch/ia64/Kconfig
+++ linux-x86.q/arch/ia64/Kconfig
@@ -351,7 +351,8 @@ config ARCH_SELECT_MEMORY_MODEL
 	def_bool y
 
 config ARCH_DISCONTIGMEM_ENABLE
-	def_bool y
+	def_bool n
+	depends on NUMA
 	help
 	  Say Y to support efficient handling of discontiguous physical memory,
 	  for architectures which are either NUMA (Non-Uniform Memory Access)
@@ -372,7 +373,7 @@ config ARCH_DISCONTIGMEM_DEFAULT
 
 config NUMA
 	bool "NUMA support"
-	depends on !IA64_HP_SIM && !FLATMEM
+	depends on !IA64_HP_SIM
 	default y if IA64_SGI_SN2
 	select ACPI_NUMA if ACPI
 	help

  reply	other threads:[~2008-01-30 19:05 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200801301414.m0UEEgCC006371@hera.kernel.org>
2008-01-30 15:27 ` x86/non-x86: percpu, node ids, apic ids x86.git fixup Geert Uytterhoeven
2008-01-30 16:02   ` Mike Travis
2008-01-30 16:10     ` Ingo Molnar
2008-01-30 17:13       ` Luck, Tony
2008-01-30 18:06         ` Ingo Molnar
2008-01-30 18:20           ` Mike Travis
2008-01-30 18:31           ` Luck, Tony
2008-01-30 18:41             ` Mike Travis
2008-01-30 18:49             ` Ingo Molnar
2008-01-30 19:05               ` Ingo Molnar [this message]
2008-01-30 19:10               ` Luck, Tony
2008-01-30 19:13               ` Olof Johansson
2008-01-30 19:18                 ` Ingo Molnar
2008-01-30 21:25                 ` [powerpc changes] " Ingo Molnar
2008-01-30 21:39                   ` Olof Johansson
2008-01-30 21:56                   ` Geoff Levand
2008-01-30 21:18               ` Geoff Levand
2008-01-30 19:17             ` Mike Travis
2008-01-30 19:30               ` Ingo Molnar
2008-01-30 19:33               ` Luck, Tony
2008-01-30 19:46                 ` Ingo Molnar
2008-01-30 19:49                   ` Ingo Molnar
2008-01-30 20:00                   ` Luck, Tony
2008-01-30 20:02                     ` Ingo Molnar
2008-01-30 20:17                       ` Luck, Tony
2008-01-30 20:59                         ` Ingo Molnar
2008-01-30 21:15                           ` Luck, Tony
2008-01-30 21:20                             ` Ingo Molnar
2008-01-31  0:57                           ` Luck, Tony
2008-01-31  9:06                             ` Ingo Molnar
2008-01-31 18:34                               ` Luck, Tony
2008-01-31 23:28                                 ` Luck, Tony
2008-02-05 19:05                                 ` Luck, Tony
2008-01-31 10:47                 ` Adrian Bunk
2008-01-30 18:35           ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080130190527.GA3681@elte.hu \
    --to=mingo@elte.hu \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).