linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: sparclinux@vger.kernel.org, linux-ia64@vger.kernel.org,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	Mike Travis <travis@sgi.com>,
	Linux/PPC Development <linuxppc-dev@ozlabs.org>,
	Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
Date: Wed, 30 Jan 2008 20:46:16 +0100	[thread overview]
Message-ID: <20080130194616.GA19426@elte.hu> (raw)
In-Reply-To: <1FE6DD409037234FAB833C420AA843EC757F12@orsmsx424.amr.corp.intel.com>


* Luck, Tony <tony.luck@intel.com> wrote:

> > This is only defined for !__ASSEMBLY__
> 
> Some place in there.  The CONFIG_SMP=n path in ia64 makes quite 
> radical changes ... rather than putting all the per-cpu stuff into the 
> top 64K of address space and providing a per-cpu TLB mapping for that 
> range to a different physical address ... it just makes all the 
> per-cpu stuff link as ordinary variables in .data.  The error messages 
> indicate that some of the new code is unaware of this.

ah, that was the vital clue. The patch below makes the small memory 
model only defined on SMP, and makes the config build/link fine here. 
Does this build and boot on your box?

	Ingo

------------>
Subject: ia64: build fix #3
From: Ingo Molnar <mingo@elte.hu>

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/asm-ia64/percpu.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-x86.q/include/asm-ia64/percpu.h
===================================================================
--- linux-x86.q.orig/include/asm-ia64/percpu.h
+++ linux-x86.q/include/asm-ia64/percpu.h
@@ -15,12 +15,12 @@
 
 #include <linux/threads.h>
 
+#ifdef CONFIG_SMP
+
 #ifdef HAVE_MODEL_SMALL_ATTRIBUTE
 # define PER_CPU_ATTRIBUTES	__attribute__((__model__ (__small__)))
 #endif
 
-#ifdef CONFIG_SMP
-
 #define __my_cpu_offset	__ia64_per_cpu_var(local_per_cpu_offset)
 
 extern void *per_cpu_init(void);

  reply	other threads:[~2008-01-30 19:46 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200801301414.m0UEEgCC006371@hera.kernel.org>
2008-01-30 15:27 ` x86/non-x86: percpu, node ids, apic ids x86.git fixup Geert Uytterhoeven
2008-01-30 16:02   ` Mike Travis
2008-01-30 16:10     ` Ingo Molnar
2008-01-30 17:13       ` Luck, Tony
2008-01-30 18:06         ` Ingo Molnar
2008-01-30 18:20           ` Mike Travis
2008-01-30 18:31           ` Luck, Tony
2008-01-30 18:41             ` Mike Travis
2008-01-30 18:49             ` Ingo Molnar
2008-01-30 19:05               ` Ingo Molnar
2008-01-30 19:10               ` Luck, Tony
2008-01-30 19:13               ` Olof Johansson
2008-01-30 19:18                 ` Ingo Molnar
2008-01-30 21:25                 ` [powerpc changes] " Ingo Molnar
2008-01-30 21:39                   ` Olof Johansson
2008-01-30 21:56                   ` Geoff Levand
2008-01-30 21:18               ` Geoff Levand
2008-01-30 19:17             ` Mike Travis
2008-01-30 19:30               ` Ingo Molnar
2008-01-30 19:33               ` Luck, Tony
2008-01-30 19:46                 ` Ingo Molnar [this message]
2008-01-30 19:49                   ` Ingo Molnar
2008-01-30 20:00                   ` Luck, Tony
2008-01-30 20:02                     ` Ingo Molnar
2008-01-30 20:17                       ` Luck, Tony
2008-01-30 20:59                         ` Ingo Molnar
2008-01-30 21:15                           ` Luck, Tony
2008-01-30 21:20                             ` Ingo Molnar
2008-01-31  0:57                           ` Luck, Tony
2008-01-31  9:06                             ` Ingo Molnar
2008-01-31 18:34                               ` Luck, Tony
2008-01-31 23:28                                 ` Luck, Tony
2008-02-05 19:05                                 ` Luck, Tony
2008-01-31 10:47                 ` Adrian Bunk
2008-01-30 18:35           ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080130194616.GA19426@elte.hu \
    --to=mingo@elte.hu \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).