build error with kdump shutdown hook support

build error with kdump shutdown hook support

[Geoff Levand]

Hi.

It seems something is missing in the current
linux-2.6.git (8af03e782cae1e0a0f530ddd22301cdd12cf9dc0).

  CC      arch/powerpc/kernel/crash.o
arch/powerpc/kernel/crash.c: In function 'default_machine_crash_shutdown':
arch/powerpc/kernel/crash.c:388: error: '__debugger_fault_handler' undeclared (first use in this function)
arch/powerpc/kernel/crash.c:388: error: (Each undeclared identifier is reported only once
arch/powerpc/kernel/crash.c:388: error: for each function it appears in.)


commit 496b010e1e70a9b4286fa34f19523f24a194f119
Author: Michael Neuling <mikey@neuling.org>
Date:   Fri Jan 18 15:50:30 2008 +1100

    [POWERPC] kdump shutdown hook support

    This adds hooks into the default_machine_crash_shutdown so drivers can
    register a function to be run in the first kernel before we hand off
    to the second kernel.  This should only be used in exceptional
    circumstances, like where the device can't be reset in the second
    kernel alone (as is the case with eHEA).  To emphasize this, the
    number of handles allowed to be registered is currently #def to 1.

    This uses the setjmp/longjmp code around the call out to the
    registered hooks, so any bogus exceptions we encounter will hopefully
    be recoverable.

    Tested with bogus data and instruction exceptions.

    Signed-off-by: Michael Neuling <mikey@neuling.org>
    Signed-off-by: Paul Mackerras <paulus@samba.org>

Re: build error with kdump shutdown hook support

[Olof Johansson]

On Wed, Jan 30, 2008 at 07:22:19PM -0800, Geoff Levand wrote:
> Hi.
> 
> It seems something is missing in the current
> linux-2.6.git (8af03e782cae1e0a0f530ddd22301cdd12cf9dc0).

See:

http://patchwork.ozlabs.org/linuxppc/patch?id=16607

Or add a separate handler instead of reusing the debugger one, either
way works for me. I went with the easier option.

-Olof