From: Nathan Lynch <ntl@pobox.com>
To: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] Xilinx: hwicap driver
Date: Thu, 31 Jan 2008 23:56:14 -0600 [thread overview]
Message-ID: <20080201055613.GY14201@localdomain> (raw)
In-Reply-To: <20080201050228.7A6E117C0053@mail145-dub.bigfish.com>
Stephen Neuendorffer wrote:
>
> +static ssize_t
> +hwicap_read(struct file *file, char *buf, size_t count, loff_t *ppos)
> +{
> + struct hwicap_drvdata *drvdata = file->private_data;
> + ssize_t bytes_to_read = 0;
> + u32 *kbuf;
> + u32 words;
> + u32 bytes_remaining;
> + int status;
> +
> + spin_lock(&hwicap_spinlock);
> + if (drvdata->is_accessing)
> + return -EBUSY;
Need to unlock before returning (several places in this patch).
next prev parent reply other threads:[~2008-02-01 5:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1201805233-15112-1-git-send-email-stephen.neuendorffer@xilinx.com>
2008-02-01 1:02 ` [PATCH] [POWERPC] Xilinx: hwicap driver Stephen Neuendorffer
2008-02-01 5:21 ` Grant Likely
[not found] ` <1201827769-7439-1-git-send-email-stephen.neuendorffer@xilinx.com>
2008-02-01 5:01 ` Stephen Neuendorffer
2008-02-01 5:56 ` Nathan Lynch [this message]
2008-02-01 17:31 ` Stephen Neuendorffer
2008-02-01 18:22 ` Stephen Neuendorffer
2008-02-01 18:42 ` Grant Likely
[not found] <47AB6552.7040503@gmail.com>
2008-02-08 2:17 ` Stephen Neuendorffer
2008-02-08 9:10 ` Jiri Slaby
2008-02-08 16:49 ` Randy Dunlap
[not found] <1201890163-12219-1-git-send-email-stephen.neuendorffer@xilinx.com>
2008-02-01 20:03 ` Stephen Neuendorffer
2008-02-01 20:11 ` Grant Likely
2008-02-01 21:12 ` Stephen Neuendorffer
[not found] ` <1201900363-25230-1-git-send-email-stephen.neuendorffer@xilinx.com>
2008-02-05 0:38 ` Stephen Neuendorffer
2007-12-05 12:20 [PATCH] [XILINX][HWICAP] Xilinx Internal Configuration Access Port device driver Peter Korsgaard
2008-01-31 18:47 ` [PATCH] [POWERPC] Xilinx: hwicap driver Stephen Neuendorffer
2008-01-31 19:58 ` Grant Likely
2008-01-31 22:39 ` Stephen Neuendorffer
2008-01-31 23:12 ` Grant Likely
2008-01-31 23:51 ` Stephen Neuendorffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201055613.GY14201@localdomain \
--to=ntl@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=stephen.neuendorffer@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).