linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* ndfc ecc byte order
@ 2008-01-30 19:52 Sean MacLennan
  2008-01-30 21:01 ` Stefan Roese
  0 siblings, 1 reply; 4+ messages in thread
From: Sean MacLennan @ 2008-01-30 19:52 UTC (permalink / raw)
  To: linuxppc-dev

There seems to be a byte order conflict between the u-boot and Linux 
ndfc drivers.

u-boot has the following:

    /* The NDFC uses Smart Media (SMC) bytes order*/
    ecc_code[0] = p[2];
    ecc_code[1] = p[1];
    ecc_code[2] = p[3];

the kernel has:

    ecc_code[0] = p[1];
    ecc_code[1] = p[2];
    ecc_code[2] = p[3];

I think u-boot has it right since u-boot and kernel software calculated 
ECCs agree. Anybody know a reason *not* to switch to the SMC byte order?

Note that the kernel version will work if you are reading/writing from 
the kernel since they agree on the wrong ECC :p

Cheers,
   Sean

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-02-01  8:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-30 19:52 ndfc ecc byte order Sean MacLennan
2008-01-30 21:01 ` Stefan Roese
2008-02-01  8:12   ` Stefan Roese
2008-02-01  8:34     ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).