* [PATCH 2/3] powerpc: fsl_soc: fix mpc83xx_spi device registration
@ 2008-02-02 0:09 Kim Phillips
2008-02-06 5:44 ` Kumar Gala
0 siblings, 1 reply; 2+ messages in thread
From: Kim Phillips @ 2008-02-02 0:09 UTC (permalink / raw)
To: linuxppc-dev
calling platform_device_register after platform_device_alloc causes
this:
kobject (c3841a70): tried to init an initialized object, something is seriously wrong.
Call Trace:
[c381fe20] [c0007bb8] show_stack+0x3c/0x194 (unreliable)
[c381fe50] [c01322a8] kobject_init+0xb8/0xbc
[c381fe60] [c01591cc] device_initialize+0x30/0x9c
[c381fe80] [c015ee34] platform_device_register+0x1c/0x34
[c381fea0] [c02f1fe0] of_fsl_spi_probe+0x21c/0x22c
[c381ff30] [c02f2044] fsl_spi_init+0x54/0x160
[c381ff60] [c02f3924] __machine_initcall_mpc832x_rdb_mpc832x_spi_init+0x120/0x138
[c381ff70] [c02e61b4] kernel_init+0x98/0x284
[c381fff0] [c000f740] kernel_thread+0x44/0x60
fixed by calling platform_device_add (second half of
platform_device_register) instead.
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
arch/powerpc/sysdev/fsl_soc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
index e48b20e..2c5388c 100644
--- a/arch/powerpc/sysdev/fsl_soc.c
+++ b/arch/powerpc/sysdev/fsl_soc.c
@@ -1342,7 +1342,7 @@ static int __init of_fsl_spi_probe(char *type, char *compatible, u32 sysclk,
if (ret)
goto unreg;
- ret = platform_device_register(pdev);
+ ret = platform_device_add(pdev);
if (ret)
goto unreg;
--
1.5.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] powerpc: fsl_soc: fix mpc83xx_spi device registration
2008-02-02 0:09 [PATCH 2/3] powerpc: fsl_soc: fix mpc83xx_spi device registration Kim Phillips
@ 2008-02-06 5:44 ` Kumar Gala
0 siblings, 0 replies; 2+ messages in thread
From: Kumar Gala @ 2008-02-06 5:44 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev
On Feb 1, 2008, at 6:09 PM, Kim Phillips wrote:
> calling platform_device_register after platform_device_alloc causes
> this:
>
> kobject (c3841a70): tried to init an initialized object, something
> is seriously wrong.
> Call Trace:
> [c381fe20] [c0007bb8] show_stack+0x3c/0x194 (unreliable)
> [c381fe50] [c01322a8] kobject_init+0xb8/0xbc
> [c381fe60] [c01591cc] device_initialize+0x30/0x9c
> [c381fe80] [c015ee34] platform_device_register+0x1c/0x34
> [c381fea0] [c02f1fe0] of_fsl_spi_probe+0x21c/0x22c
> [c381ff30] [c02f2044] fsl_spi_init+0x54/0x160
> [c381ff60] [c02f3924] __machine_initcall_mpc832x_rdb_mpc832x_spi_init
> +0x120/0x138
> [c381ff70] [c02e61b4] kernel_init+0x98/0x284
> [c381fff0] [c000f740] kernel_thread+0x44/0x60
>
> fixed by calling platform_device_add (second half of
> platform_device_register) instead.
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
applied.
- k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-06 5:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-02 0:09 [PATCH 2/3] powerpc: fsl_soc: fix mpc83xx_spi device registration Kim Phillips
2008-02-06 5:44 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).