From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lixom.net (lixom.net [66.141.50.11]) by ozlabs.org (Postfix) with ESMTP id 938B3DDEF9 for ; Sun, 3 Feb 2008 06:12:05 +1100 (EST) Date: Sat, 2 Feb 2008 13:12:39 -0600 From: Olof Johansson To: Ben Dooks Subject: Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC Message-ID: <20080202191239.GA29039@lixom.net> References: <20080202162133.678366209@fluff.org.uk> <20080202162232.212855590@fluff.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20080202162232.212855590@fluff.org.uk> Cc: linux-ide@vger.kernel.org, htejun@gmail.com, jeff@garzik.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Feb 02, 2008 at 04:21:36PM +0000, Ben Dooks wrote: > Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM > driver. > > CC: linuxppc-dev@ozlabs.org > Signed-off-by: Ben Dooks What tree is this against? It doesn't apply to current mainline nor jgarzik's libata-dev upstream branch. Anyway: NACK: I like this approach but this needs to be added to arch/powerpc as well. It's actually more needed there than arch/ppc, I don't personally care if arch/ppc can't use pata_platform for the last couple of months it's still around (it's getting deleted this summer, all platforms should have moved to powerpc by then). -Olof