From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp05.au.ibm.com (E23SMTP05.au.ibm.com [202.81.18.174]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e23smtp05.au.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 7F309DDE1E for ; Mon, 4 Feb 2008 21:09:13 +1100 (EST) Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.18.234]) by e23smtp05.au.ibm.com (8.13.1/8.13.1) with ESMTP id m14A902t006536 for ; Mon, 4 Feb 2008 21:09:00 +1100 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m14A9CX83973202 for ; Mon, 4 Feb 2008 21:09:12 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m14A9DL7011063 for ; Mon, 4 Feb 2008 21:09:14 +1100 Date: Mon, 4 Feb 2008 15:37:43 +0530 From: Balbir Singh To: Andrew Morton , linuxppc-dev@ozlabs.org Subject: Build failure with 2.6.24-mm1 Message-ID: <20080204100743.GA4445@balbir.in.ibm.com> References: <47A6E355.8040404@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <47A6E355.8040404@linux.vnet.ibm.com> Cc: Shaohua Li , Zhang Yanmin Reply-To: balbir@linux.vnet.ibm.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Balbir Singh [2008-02-04 15:35:09]: I just saw the following build failure on a power machine. In file included from include/acpi/platform/acenv.h:140, from include/acpi/acpi.h:54, from include/acpi/acpi_bus.h:31, from drivers/pci/pcie/aspm.c:20: include/acpi/platform/aclinux.h:59:22: error: asm/acpi.h: No such file or directory In file included from include/acpi/platform/aclinux.h:120, from include/acpi/platform/acenv.h:140, from include/acpi/acpi.h:54, from include/acpi/acpi_bus.h:31, from drivers/pci/pcie/aspm.c:20: include/acpi/actypes.h:130: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'UINT64' include/acpi/actypes.h:131: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'INT64' include/acpi/actypes.h:753: error: expected ')' before '*' token include/acpi/actypes.h:756: error: expected ')' before '*' token In file included from include/acpi/acpi.h:61, from include/acpi/acpi_bus.h:31, from drivers/pci/pcie/aspm.c:20: include/acpi/acpiosxf.h:179: error: expected declaration specifiers or '...' before 'acpi_osd_handler' include/acpi/acpiosxf.h:183: error: expected declaration specifiers or '...' before 'acpi_osd_handler' include/acpi/acpiosxf.h:192: error: expected declaration specifiers or '...' before 'acpi_osd_exec_callback' make[3]: *** [drivers/pci/pcie/aspm.o] Error 1 make[2]: *** [drivers/pci/pcie] Error 2 make[2]: *** Waiting for unfinished jobs.... CC drivers/ps3/ps3-vuart.o CC net/netlink/attr.o make[1]: *** [drivers/pci] Error 2 make[1]: *** Waiting for unfinished jobs.. The following config option is responsible for the build failure config PCIEASPM bool "PCI Express ASPM support(Experimental)" depends on PCI && EXPERIMENTAL && PCIEPORTBUS default y help This enables PCI Express ASPM (Active State Power Management) and Clock Power Management. ASPM supports state L0/L0s/L1. When in doubt, say N. Here's a probable fix for the problem. Make the build of drivers/pci/pcie/aspm.c depend on ACPI. NOTE, the patch has not been tested. The dependency on ACPI might be wrong, but setting it to default "y" caused the build on my powerpc box to break. Signed-off-by: Balbir Singh --- drivers/pci/pcie/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/pci/pcie/Kconfig~fix-mm-ppc-build drivers/pci/pcie/Kconfig --- linux-2.6.24/drivers/pci/pcie/Kconfig~fix-mm-ppc-build 2008-02-04 15:30:29.000000000 +0530 +++ linux-2.6.24-balbir/drivers/pci/pcie/Kconfig 2008-02-04 15:33:45.000000000 +0530 @@ -32,7 +32,7 @@ source "drivers/pci/pcie/aer/Kconfig" # config PCIEASPM bool "PCI Express ASPM support(Experimental)" - depends on PCI && EXPERIMENTAL && PCIEPORTBUS + depends on PCI && EXPERIMENTAL && PCIEPORTBUS && ACPI default y help This enables PCI Express ASPM (Active State Power Management) and _ -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL